Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct whitespace in InvalidResourceSpecification message #3633

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

benclifford
Copy link
Collaborator

Type of change

  • Update to human readable text: Documentation/error messages/comments

@benclifford benclifford requested a review from yadudoc October 13, 2024 11:11
Comment on lines -349 to +351
("HTEX does not support the supplied resource_specifications."
("HTEX does not support the supplied resource_specifications. "
"For MPI applications consider using the MPIExecutor. "
"For specifications for core count/memory/walltime, consider using WorkQueueExecutor. ")
"For specifications for core count/memory/walltime, consider using WorkQueueExecutor.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I have found that putting the space(s) to join lines at the beginning of the following line easier to see and not leave this kind of detritus. Obviously not for this PR, but as a habit/mental trick to myself. 🤷

@benclifford benclifford merged commit 2a6bd18 into master Oct 15, 2024
7 checks passed
@benclifford benclifford deleted the benc-whitespace-mpi branch October 15, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants