Slurm tests

[tylern4]

Description

Adds in testing for slurm systems inside of a container which have come up from discussions with @benclifford in some emails and issue #3579

Changed Behaviour

More testing on slurm code.

Fixes

Fixes #3579

Type of change

• New feature

[tylern4]

The slurm tests pass with the slurm config but it seems like it's still missing some slurm tests that could be helpful. Some helping getting a good config to test everything or the right pytest settings would be appreciated!

[benclifford]

What you've got is a test that runs the "should work with most configs" tests against an environment using the SlurmProvider.

Are you asking about specific tests that you know exist but don't see running?

I think the only other slurm-related tests are these, which don't need a working slurm instance - they only check that the provider can set itself up correctly:

$ ls parsl/tests/test_providers/test_slurm_*.py
parsl/tests/test_providers/test_slurm_instantiate.py  parsl/tests/test_providers/test_slurm_template.py

Part of the reason there is that personally I have only really pushed on tests that are run automatically, rather than at-release testing that wasn't happening in reality. If this PR was merged, the automated tests would be in a much better place to get additional tests that might test specific SlurmProvider features, rather than running a full Parsl DFK.

[tylern4]

Right I saw those two tests didn't run when I added the Slurm Config but if they are okay to be left off then I think this is good to go.

[benclifford]

I think this line isn't needed and you got it by cut and pasting it from somewhere else that also doesn't need it... it also causes trouble in some situations by making configs be initialized at import (so every single test config gets initialised on every test run), rather than when the config is actually wanted.

[benclifford]

I saw those two tests didn't run when I added the Slurm Config

They get run in a different part of testing, because they are marked with pytest.mark.local - because they aren't tied to being run with any particular configuration.