Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce flake8 max-line-length and Updated the read me #3169

Closed
wants to merge 9 commits into from
Closed

Reduce flake8 max-line-length and Updated the read me #3169

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5594c02
Reduce flake8 max-line-length
OfficialOzioma Mar 6, 2024
1e55f80
Reduce flake8 max-line-length and updated read me
OfficialOzioma Mar 6, 2024
1d9ded1
Reduce flake8 max-line-length and updated read me
OfficialOzioma Mar 6, 2024
4dee5cd
removed unnessary files and folders
OfficialOzioma Mar 6, 2024
3eabe6f
removed .deps file
OfficialOzioma Mar 6, 2024
061dd9b
Merge branch 'master' of github.com:Parsl/parsl
OfficialOzioma Mar 9, 2024
3f8f175
I removed white space and add comment
OfficialOzioma Mar 9, 2024
ca814bd
Merge branch 'Parsl:master' into master
OfficialOzioma Mar 17, 2024
efdc21c
Merge branch 'master' into master
OfficialOzioma Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,12 @@ For Developers
$ make # show all available makefile targets
$ make virtualenv # create a virtual environment
$ source .venv/bin/activate # activate the virtual environment
$ You may need to install ``mpich`` Run "sudo apt install mpich" # for example, if you using ubuntu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely useful information to have. Since this line is meant as a comment I would add a # prefix like:
$ # You may need to install ...

$ make deps # install python dependencies from test-requirements.txt
$ make test # make (all) tests. Run "make config_local_test" for a faster, smaller test set.
$ make clean # remove virtualenv and all test and build artifacts


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this was an unintentional whitespace added here, I'd recommend removing it.

3. Install::

$ cd parsl
Expand Down
5 changes: 2 additions & 3 deletions parsl/monitoring/db_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,10 +524,9 @@ def start(self,
reprocessable_first_resource_messages.append(msg)
else:
if task_try_id in deferred_resource_messages:
logger.error(
"Task {} already has a deferred resource message. "
error_message = "Task {} already has a deferred resource message . " \
"Discarding previous message.".format(msg['task_id'])
)
logger.error(error_message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

deferred_resource_messages[task_try_id] = msg
elif msg['last_msg']:
# This assumes that the primary key has been added
Expand Down
Loading