Reduce flake8 max-line-length and Updated the read me #3169
Conversation
|
@benclifford please take a look at this if you are available |
There was a problem hiding this comment.
Hi @OfficialOzioma, thanks for these changes! I've made some recommendations for some minor changes, but otherwise, everything in this PR looks great.
Once you've worked on the changes, we can have this PR merged. Nice job!
README.rst
Outdated
| @@ -96,10 +96,12 @@ For Developers | |||
| $ make # show all available makefile targets | |||
| $ make virtualenv # create a virtual environment | |||
| $ source .venv/bin/activate # activate the virtual environment | |||
| $ You may need to install ``mpich`` Run "sudo apt install mpich" # for example, if you using ubuntu | |||
There was a problem hiding this comment.
This is definitely useful information to have. Since this line is meant as a comment I would add a # prefix like:
$ # You may need to install ...
README.rst
Outdated
| $ make deps # install python dependencies from test-requirements.txt | ||
| $ make test # make (all) tests. Run "make config_local_test" for a faster, smaller test set. | ||
| $ make clean # remove virtualenv and all test and build artifacts | ||
|
|
||
|
|
There was a problem hiding this comment.
If this was an unintentional whitespace added here, I'd recommend removing it.
| "Discarding previous message.".format(msg['task_id']) | ||
| ) | ||
| logger.error(error_message) |
|
thank you @yadudoc , I removed the whitespace and added the comments. Please review, 🙏 |
|
The Outreachy application period is over, so I'm closing your PR - thanks for your participation in Parsl+Outreachy so far! |
Description
Follow the instructions on #3105
Changed Behaviour
I reduced the max-line length and updated the parsl/monitoring/db_manager.py file
I also update the readme file
Fixes
Fixes # (issue)
Type of change