added docker check to workflow #2414
Conversation
WalkthroughThis pull request introduces significant updates to the Talawa Admin application, including the addition of a new GitHub Actions job named Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (2)
.github/workflows/pull-request.yml (2)
278-283: Improve cleanup step reliability.The cleanup steps should handle errors gracefully and verify container existence.
Apply this diff to improve cleanup reliability:
- name: Stop Docker Container if: always() run: | - docker stop talawa-admin-app-container - docker rm talawa-admin-app-container + if docker ps -a | grep -q talawa-admin-app-container; then + docker stop talawa-admin-app-container || true + docker rm talawa-admin-app-container || true + fi🧰 Tools
🪛 yamllint
[error] 278-278: trailing spaces
(trailing-spaces)
[error] 283-283: trailing spaces
(trailing-spaces)
256-284: Consider enhancing the Docker check implementation.While this implementation addresses the basic requirement of checking if the app starts in Docker, consider these architectural improvements:
- Add environment variables for configuration (ports, timeouts, etc.)
- Consider using Docker Compose for more complex setups
- Add logging of container output for debugging failures
- Consider implementing smoke tests beyond basic health checks
Would you like assistance in implementing any of these improvements?
🧰 Tools
🪛 actionlint
259-259: could not parse as YAML: yaml: line 259: did not find expected '-' indicator
(syntax-check)
🪛 yamllint
[warning] 257-257: wrong indentation: expected 4 but found 10
(indentation)
[warning] 260-260: wrong indentation: expected 12 but found 13
(indentation)
[error] 261-261: syntax error: expected , but found '?'
(syntax)
[error] 262-262: trailing spaces
(trailing-spaces)
[warning] 264-264: wrong indentation: expected 15 but found 13
(indentation)
[error] 267-267: trailing spaces
(trailing-spaces)
[warning] 268-268: wrong indentation: expected 15 but found 14
(indentation)
[error] 271-271: trailing spaces
(trailing-spaces)
[warning] 273-273: wrong indentation: expected 16 but found 15
(indentation)
[error] 275-275: trailing spaces
(trailing-spaces)
[error] 277-277: trailing spaces
(trailing-spaces)
[error] 278-278: trailing spaces
(trailing-spaces)
[error] 283-283: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/pull-request.yml(1 hunks)
🧰 Additional context used
🪛 actionlint
.github/workflows/pull-request.yml
259-259: could not parse as YAML: yaml: line 259: did not find expected '-' indicator
(syntax-check)
🪛 yamllint
.github/workflows/pull-request.yml
[warning] 257-257: wrong indentation: expected 4 but found 10
(indentation)
[warning] 260-260: wrong indentation: expected 12 but found 13
(indentation)
[error] 261-261: syntax error: expected , but found '?'
(syntax)
[error] 262-262: trailing spaces
(trailing-spaces)
[warning] 264-264: wrong indentation: expected 15 but found 13
(indentation)
[error] 267-267: trailing spaces
(trailing-spaces)
[warning] 268-268: wrong indentation: expected 15 but found 14
(indentation)
[error] 271-271: trailing spaces
(trailing-spaces)
[warning] 273-273: wrong indentation: expected 16 but found 15
(indentation)
[error] 275-275: trailing spaces
(trailing-spaces)
[error] 277-277: trailing spaces
(trailing-spaces)
[error] 278-278: trailing spaces
(trailing-spaces)
[error] 283-283: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
.github/workflows/pull-request.yml (1)
275-295: Enhance health check implementation for better debugging.While the current implementation with timeout and retry logic is good, consider these improvements:
- Add more detailed error messages
- Include debug logging
- Add comprehensive health checks
Apply this diff to enhance the implementation:
- name: Check if Talawa Admin App is running run: | timeout=60 while ! nc -z localhost 8080 && [ $timeout -gt 0 ]; do + echo "Waiting for application to start... ($timeout seconds remaining)" sleep 1 timeout=$((timeout-1)) done if [ $timeout -eq 0 ]; then - echo "Timeout waiting for application to start" + echo "Error: Application failed to start within 60 seconds" + echo "Docker logs:" + docker logs talawa-admin-app-container exit 1 fi # Retry curl up to 3 times with 5s delay for i in {1..3}; do + echo "Attempt $i/3: Checking application health..." if curl --fail --silent http://localhost:8080/index.html; then + echo "Application is healthy!" exit 0 fi + echo "Health check failed, retrying in 5 seconds..." sleep 5 done + echo "Error: Application health check failed after 3 attempts" + echo "Docker logs:" + docker logs talawa-admin-app-container exit 1🧰 Tools
🪛 yamllint
[error] 282-282: trailing spaces
(trailing-spaces)
[error] 287-287: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/pull-request.yml(1 hunks)
🧰 Additional context used
🪛 actionlint
.github/workflows/pull-request.yml
260-260: could not parse as YAML: yaml: line 260: did not find expected '-' indicator
(syntax-check)
🪛 yamllint
.github/workflows/pull-request.yml
[warning] 257-257: wrong indentation: expected 4 but found 10
(indentation)
[warning] 261-261: wrong indentation: expected 12 but found 13
(indentation)
[error] 262-262: syntax error: expected , but found '?'
(syntax)
[error] 263-263: trailing spaces
(trailing-spaces)
[warning] 265-265: wrong indentation: expected 15 but found 13
(indentation)
[error] 266-266: trailing spaces
(trailing-spaces)
[error] 270-270: trailing spaces
(trailing-spaces)
[warning] 271-271: wrong indentation: expected 10 but found 12
(indentation)
[error] 282-282: trailing spaces
(trailing-spaces)
[error] 287-287: trailing spaces
(trailing-spaces)
[error] 296-296: trailing spaces
(trailing-spaces)
[error] 297-297: trailing spaces
(trailing-spaces)
[error] 302-302: trailing spaces
(trailing-spaces)
🔇 Additional comments (2)
.github/workflows/pull-request.yml (2)
267-273: LGTM! Docker configuration is properly set up.
The Docker build and run configuration is correct with:
- Proper image tagging
- Correct port mapping
- Consistent container naming
🧰 Tools
🪛 yamllint
[error] 270-270: trailing spaces
(trailing-spaces)
[warning] 271-271: wrong indentation: expected 10 but found 12
(indentation)
297-302: LGTM! Cleanup steps are properly configured.
The cleanup configuration ensures proper resource cleanup by:
- Running regardless of previous step outcomes (
if: always()) - Properly stopping and removing the container
🧰 Tools
🪛 yamllint
[error] 297-297: trailing spaces
(trailing-spaces)
[error] 302-302: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Outside diff range and nitpick comments (1)
.github/workflows/pull-request.yml (1)
256-288: Consider enhancing error handling and logging.While the implementation meets the basic requirements, consider these improvements for better debugging and reliability:
- Add error logging for Docker build failures
- Log container status before health checks
- Preserve logs on failure for debugging
Example enhancement:
- name: Build Docker image run: | + # Log Docker version and system info + docker version + docker info docker build -t talawa-admin-app . || { + echo "Docker build failed. Check the logs above for details." + exit 1 + } - name: Run Docker Container run: | docker run -d --name talawa-admin-app-container -p 8080:8080 talawa-admin-app + # Log container status + docker ps + docker logs talawa-admin-app-container🧰 Tools
🪛 actionlint
260-260: could not parse as YAML: yaml: line 260: did not find expected '-' indicator
(syntax-check)
🪛 yamllint
[warning] 257-257: wrong indentation: expected 4 but found 10
(indentation)
[warning] 261-261: wrong indentation: expected 12 but found 13
(indentation)
[error] 262-262: syntax error: expected , but found '?'
(syntax)
[error] 263-263: trailing spaces
(trailing-spaces)
[warning] 265-265: wrong indentation: expected 15 but found 13
(indentation)
[error] 266-266: trailing spaces
(trailing-spaces)
[error] 270-270: trailing spaces
(trailing-spaces)
[warning] 271-271: wrong indentation: expected 10 but found 12
(indentation)
[error] 281-281: trailing spaces
(trailing-spaces)
[error] 282-282: trailing spaces
(trailing-spaces)
[error] 287-287: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/pull-request.yml(1 hunks)
🧰 Additional context used
🪛 actionlint
.github/workflows/pull-request.yml
260-260: could not parse as YAML: yaml: line 260: did not find expected '-' indicator
(syntax-check)
🪛 yamllint
.github/workflows/pull-request.yml
[warning] 257-257: wrong indentation: expected 4 but found 10
(indentation)
[warning] 261-261: wrong indentation: expected 12 but found 13
(indentation)
[error] 262-262: syntax error: expected , but found '?'
(syntax)
[error] 263-263: trailing spaces
(trailing-spaces)
[warning] 265-265: wrong indentation: expected 15 but found 13
(indentation)
[error] 266-266: trailing spaces
(trailing-spaces)
[error] 270-270: trailing spaces
(trailing-spaces)
[warning] 271-271: wrong indentation: expected 10 but found 12
(indentation)
[error] 281-281: trailing spaces
(trailing-spaces)
[error] 282-282: trailing spaces
(trailing-spaces)
[error] 287-287: trailing spaces
(trailing-spaces)
varshith257
requested review from
AVtheking,
gautam-divyanshu and
pranshugupta54
There was a problem hiding this comment.
Looks like there's an error in the YAML file—possibly due to formatting or indentation.
Check: https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/11741762559/workflow#L260
Yes you are right, there is indentation error due to which the workflow is not triggered. I am working on it. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (4)
.github/workflows/pull-request.yml (4)
267-273: Add error handling for Docker build and run steps.The Docker build and run steps should include error handling to provide clear feedback if they fail.
- name: Build Docker image run: | + if ! docker build -t talawa-admin-app .; then + echo "Failed to build Docker image" + exit 1 + fi - docker build -t talawa-admin-app . - name: Run Docker Container run: | + if ! docker run -d --name talawa-admin-app-container -p 8080:8080 talawa-admin-app; then + echo "Failed to start Docker container" + exit 1 + fi - docker run -d --name talawa-admin-app-container -p 8080:8080 talawa-admin-app🧰 Tools
🪛 yamllint
[error] 270-270: trailing spaces
(trailing-spaces)
275-286: Enhance health check with HTTP status code verification.The current health check only verifies if the index page is accessible. It should also verify the HTTP status code to ensure the application is responding correctly.
- name: Check if Talawa Admin App is running run: | timeout=60 while ! nc -z localhost 8080 && [ $timeout -gt 0 ]; do sleep 1 timeout=$((timeout-1)) done if [ $timeout -eq 0 ]; then echo "Timeout waiting for application to start" exit 1 fi - curl --fail --silent http://localhost:8080/index.html || exit 1 + response=$(curl -s -w "%{http_code}" http://localhost:8080/index.html -o /dev/null) + if [ "$response" != "200" ]; then + echo "Application health check failed with status code: $response" + exit 1 + fi
288-292: Add error handling to cleanup step.The cleanup step should handle errors gracefully and provide feedback if the container cannot be stopped or removed.
- name: Stop Docker Container if: always() run: | - docker stop talawa-admin-app-container - docker rm talawa-admin-app-container + if ! docker stop talawa-admin-app-container; then + echo "Warning: Failed to stop Docker container" + fi + if ! docker rm talawa-admin-app-container; then + echo "Warning: Failed to remove Docker container" + fi🧰 Tools
🪛 yamllint
[error] 288-288: trailing spaces
(trailing-spaces)
263-263: Fix trailing spaces in YAML file.Remove trailing spaces to maintain consistent formatting and comply with YAML best practices.
- uses: actions/checkout@v4 + uses: actions/checkout@v4 - uses: docker/setup-buildx-action@v3 + uses: docker/setup-buildx-action@v3 - docker build -t talawa-admin-app . + docker build -t talawa-admin-app . - curl --fail --silent http://localhost:8080/index.html || exit 1 + curl --fail --silent http://localhost:8080/index.html || exit 1 - - name: Stop Docker Container + - name: Stop Docker Container - docker rm talawa-admin-app-container + docker rm talawa-admin-app-containerAlso applies to: 266-266, 270-270, 287-287, 288-288, 293-293
🧰 Tools
🪛 yamllint
[error] 263-263: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/pull-request.yml(2 hunks)
🧰 Additional context used
🪛 yamllint
.github/workflows/pull-request.yml
[error] 263-263: trailing spaces
(trailing-spaces)
[error] 266-266: trailing spaces
(trailing-spaces)
[error] 270-270: trailing spaces
(trailing-spaces)
[error] 287-287: trailing spaces
(trailing-spaces)
[error] 288-288: trailing spaces
(trailing-spaces)
[error] 293-293: trailing spaces
(trailing-spaces)
[error] 304-304: no new line character at the end of file
(new-line-at-end-of-file)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2414 +/- ##
========================================
Coverage 98.26% 98.26%
========================================
Files 297 297
Lines 8638 8638
Branches 2486 2486
========================================
Hits 8488 8488
Misses 139 139
Partials 11 11 ☔ View full report in Codecov by Sentry. |
|
@palisadoes I am still surprised as we don't have any Dockerfile in talawa-admin and how we can support this workflow though 😄 |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
.github/workflows/pull-request.yml (4)
261-266: Consider using Docker layer caching for faster builds.While the current setup works, you could optimize the Docker build process by enabling layer caching.
- name: Set up Docker uses: docker/setup-buildx-action@v3 + with: + buildkitd-flags: --debug + driver-opts: | + image=moby/buildkit:latest + cache-from: type=gha + cache-to: type=gha,mode=max🧰 Tools
🪛 yamllint
[error] 263-263: trailing spaces
(trailing-spaces)
[error] 266-266: trailing spaces
(trailing-spaces)
267-274: Add Docker build error handling and logging.The Docker build and run steps could benefit from additional error handling and logging.
- name: Build Docker image run: | + set -e + echo "Building Docker image..." docker build -t talawa-admin-app . + echo "Docker image built successfully" - name: Run Docker Container run: | + set -e + echo "Starting Docker container..." docker run -d --name talawa-admin-app-container -p 8080:8080 talawa-admin-app + echo "Docker container started successfully"🧰 Tools
🪛 yamllint
[error] 270-270: trailing spaces
(trailing-spaces)
Line range hint
256-304: Fix trailing whitespace issues.There are several trailing whitespace issues in the YAML file that should be cleaned up.
- - name: Set up Docker - uses: docker/setup-buildx-action@v3 - + - name: Set up Docker + uses: docker/setup-buildx-action@v3 - - name: Stop Docker Container + - name: Stop Docker Container🧰 Tools
🪛 yamllint
[error] 263-263: trailing spaces
(trailing-spaces)
[error] 266-266: trailing spaces
(trailing-spaces)
[error] 270-270: trailing spaces
(trailing-spaces)
[error] 287-287: trailing spaces
(trailing-spaces)
[error] 288-288: trailing spaces
(trailing-spaces)
[error] 293-293: trailing spaces
(trailing-spaces)
304-304: Add newline at end of file.Add a newline character at the end of the file to comply with POSIX standards.
exit 1 +🧰 Tools
🪛 yamllint
[error] 304-304: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/pull-request.yml(2 hunks)
🧰 Additional context used
🪛 yamllint
.github/workflows/pull-request.yml
[error] 263-263: trailing spaces
(trailing-spaces)
[error] 266-266: trailing spaces
(trailing-spaces)
[error] 270-270: trailing spaces
(trailing-spaces)
[error] 287-287: trailing spaces
(trailing-spaces)
[error] 288-288: trailing spaces
(trailing-spaces)
[error] 293-293: trailing spaces
(trailing-spaces)
[error] 304-304: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
.github/workflows/pull-request.yml (3)
256-260: LGTM! Job configuration is well structured.
The job configuration is correctly set up with appropriate dependencies on both Code-Quality-Checks and Test-Application jobs, ensuring proper sequencing of checks.
275-287: Health check implementation looks robust.
The health check implementation includes a good timeout mechanism and proper error handling. The 60-second timeout is reasonable for container startup.
🧰 Tools
🪛 yamllint
[error] 287-287: trailing spaces
(trailing-spaces)
288-292: LGTM! Cleanup step is properly configured.
The cleanup step is correctly set up with if: always() to ensure container cleanup regardless of previous step results.
🧰 Tools
🪛 yamllint
[error] 288-288: trailing spaces
(trailing-spaces)
Hey @varshith257, Can i create a DockerFile ? |
|
Check #1075 |
Yes, @varshith257 I checked this and i found out that there is an empty Dockerfile so at this point can i make a docker file with proper code? |
|
This is video demonstrating that everything is working well talawa-admin-v1.mp4 |
|
I have video of building docker image as well but video is too long |
palisadoes
merged commit 15513f5
into
PalisadoesFoundation:develop
|
@VanshikaSabharwal Please open another PR with the same changes against the |
okay |
* advertisement and plugin screen * added revamped design * fixes added * fixed testcases * chore(deps): bump sass from 1.80.6 to 1.80.7 (#2433) Bumps [sass](https://github.com/sass/dart-sass) from 1.80.6 to 1.80.7. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.80.6...1.80.7) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump eslint-plugin-import from 2.30.0 to 2.31.0 (#2434) Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.30.0...v2.31.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @mui/x-charts from 7.22.1 to 7.22.2 (#2435) Bumps [@mui/x-charts](https://github.com/mui/mui-x/tree/HEAD/packages/x-charts) from 7.22.1 to 7.22.2. - [Release notes](https://github.com/mui/mui-x/releases) - [Changelog](https://github.com/mui/mui-x/blob/v7.22.2/CHANGELOG.md) - [Commits](https://github.com/mui/mui-x/commits/v7.22.2/packages/x-charts) --- updated-dependencies: - dependency-name: "@mui/x-charts" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @types/react from 18.3.3 to 18.3.12 (#2436) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.3 to 18.3.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update pull-request.yml * Update dependabot.yaml * added docker check to workflow (#2414) * added docker check to workflow * made recommended changes to docker check in workflow * added changes to docker check inn workflow as recommended * added changes * updated indentation in pull-request.yml file * updated indentation in pull-request.yml file * added Dockerfile and Docker-compose.yml file * added Dockerfile and Docker-compose.yml file * updated .docker-ignore file * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * properly formatted code * trying to make docker check pass * trying to make docker check pass * updated INSTALLATION.md * updated INSTALLATION.md * added recommended changes to INSTALLATION.md * added recommended changes to INSTALLATION.md * added recommended changes to INSTALLATION.md * updated docker workflow * updated INSTALLATION.md * eslint-rule-no_unused_vars (#2428) * Updated pr template with checklist (#2454) * Updated pr template with checklist * Additional changes for the PR template * Changed the url for the PR template * refactored addOnStore * refactored addOnEntry v1 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Vanshika Sabharwal <[email protected]> Co-authored-by: prayansh_chhablani <[email protected]> Co-authored-by: Dhiraj Udhani <[email protected]>
* advertisement and plugin screen * added revamped design * fixes added * fixed testcases * chore(deps): bump sass from 1.80.6 to 1.80.7 (PalisadoesFoundation#2433) Bumps [sass](https://github.com/sass/dart-sass) from 1.80.6 to 1.80.7. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.80.6...1.80.7) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump eslint-plugin-import from 2.30.0 to 2.31.0 (PalisadoesFoundation#2434) Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.30.0...v2.31.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @mui/x-charts from 7.22.1 to 7.22.2 (PalisadoesFoundation#2435) Bumps [@mui/x-charts](https://github.com/mui/mui-x/tree/HEAD/packages/x-charts) from 7.22.1 to 7.22.2. - [Release notes](https://github.com/mui/mui-x/releases) - [Changelog](https://github.com/mui/mui-x/blob/v7.22.2/CHANGELOG.md) - [Commits](https://github.com/mui/mui-x/commits/v7.22.2/packages/x-charts) --- updated-dependencies: - dependency-name: "@mui/x-charts" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @types/react from 18.3.3 to 18.3.12 (PalisadoesFoundation#2436) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.3 to 18.3.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update pull-request.yml * Update dependabot.yaml * added docker check to workflow (PalisadoesFoundation#2414) * added docker check to workflow * made recommended changes to docker check in workflow * added changes to docker check inn workflow as recommended * added changes * updated indentation in pull-request.yml file * updated indentation in pull-request.yml file * added Dockerfile and Docker-compose.yml file * added Dockerfile and Docker-compose.yml file * updated .docker-ignore file * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * properly formatted code * trying to make docker check pass * trying to make docker check pass * updated INSTALLATION.md * updated INSTALLATION.md * added recommended changes to INSTALLATION.md * added recommended changes to INSTALLATION.md * added recommended changes to INSTALLATION.md * updated docker workflow * updated INSTALLATION.md * eslint-rule-no_unused_vars (PalisadoesFoundation#2428) * Updated pr template with checklist (PalisadoesFoundation#2454) * Updated pr template with checklist * Additional changes for the PR template * Changed the url for the PR template * refactored addOnStore * refactored addOnEntry v1 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Vanshika Sabharwal <[email protected]> Co-authored-by: prayansh_chhablani <[email protected]> Co-authored-by: Dhiraj Udhani <[email protected]>
* refactored OrganizationDashboard css/ closes #2513 * refactor:OrganizationDashboard_css(fixes #2513) * Plugin and advertisement screen revamp (#2006) * advertisement and plugin screen * added revamped design * fixes added * fixed testcases * chore(deps): bump sass from 1.80.6 to 1.80.7 (#2433) Bumps [sass](https://github.com/sass/dart-sass) from 1.80.6 to 1.80.7. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](sass/dart-sass@1.80.6...1.80.7) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump eslint-plugin-import from 2.30.0 to 2.31.0 (#2434) Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.30.0...v2.31.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @mui/x-charts from 7.22.1 to 7.22.2 (#2435) Bumps [@mui/x-charts](https://github.com/mui/mui-x/tree/HEAD/packages/x-charts) from 7.22.1 to 7.22.2. - [Release notes](https://github.com/mui/mui-x/releases) - [Changelog](https://github.com/mui/mui-x/blob/v7.22.2/CHANGELOG.md) - [Commits](https://github.com/mui/mui-x/commits/v7.22.2/packages/x-charts) --- updated-dependencies: - dependency-name: "@mui/x-charts" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump @types/react from 18.3.3 to 18.3.12 (#2436) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.3.3 to 18.3.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update pull-request.yml * Update dependabot.yaml * added docker check to workflow (#2414) * added docker check to workflow * made recommended changes to docker check in workflow * added changes to docker check inn workflow as recommended * added changes * updated indentation in pull-request.yml file * updated indentation in pull-request.yml file * added Dockerfile and Docker-compose.yml file * added Dockerfile and Docker-compose.yml file * updated .docker-ignore file * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * added recommended changes by code rabbit * properly formatted code * trying to make docker check pass * trying to make docker check pass * updated INSTALLATION.md * updated INSTALLATION.md * added recommended changes to INSTALLATION.md * added recommended changes to INSTALLATION.md * added recommended changes to INSTALLATION.md * updated docker workflow * updated INSTALLATION.md * eslint-rule-no_unused_vars (#2428) * Updated pr template with checklist (#2454) * Updated pr template with checklist * Additional changes for the PR template * Changed the url for the PR template * refactored addOnStore * refactored addOnEntry v1 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Vanshika Sabharwal <[email protected]> Co-authored-by: prayansh_chhablani <[email protected]> Co-authored-by: Dhiraj Udhani <[email protected]> * refactored: CSS files in src/screens/OrgSettings(fixes: #2523) (#2610) * refactored: CSS files in src/screens/OrgSettings(fixes: #2523) * refactored: CSS files in src/screens/OrgSettings(fixes: #2523) * refactored: CSS files in src/screens/OrgSettings(fixes: #2523) * refactored: CSS files in src/screens/OrgSettings(fixes: #2523) * Update pull-request.yml * refactored: CSS files in src/screens/OrganizationDashboard(fixes: #2513) * refactored: CSS files in src/screens/OrganizationDashboard(fixes: #2513) * improve import for global css --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Shekhar Patel <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: Vanshika Sabharwal <[email protected]> Co-authored-by: prayansh_chhablani <[email protected]> Co-authored-by: Dhiraj Udhani <[email protected]>
What kind of change does this PR introduce?
bugfix, feature request
Issue Number:
Fixes #2402
Did you add tests for your changes?
No
Snapshots/Videos:
If relevant, did you update the documentation?
Not relevent
Summary
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit
Release Notes
New Features
Dockerfilefor streamlined application deployment.Enhancements
.dockerignoreto optimize Docker image builds by excluding unnecessary files.These changes aim to improve the development and deployment experience for users.