-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated UI for Admin-> User Profile #1667
Updated UI for Admin-> User Profile #1667
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@pranshugupta54 Please fix the failing tests. |
Hey @Cioppolo14, sorry for the delay. I've fixed the test for MemberDetail, all the 9 tests are passing for the file. |
Fixed lint issue, failed test |
@pranshugupta54 Are you working on the test application check? |
@Cioppolo14, fixed those! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the following
- Date input for birthdate
- Placeholders for all the inputs
- Select input for Employment and Marital Status
- Choose file grey btn should be of our theme colour
Hey @rishav-jha-mech,
Loom: https://www.loom.com/share/e38979b3d9f04e77b144022648e9a0cd?sid=63c58790-3fcf-4c56-82fa-457d1edb16a0 |
@pranshugupta54 Please fix the test application check. |
Hey @Cioppolo14, fixed the failing tests for MemberDetails |
This is an update on the PR merging freeze:
We decided to do this at the beginning of the weekend to give us all time to adjust PR code and create bug fixes that may arise. Update your code at or after midnight GMT on the morning of March 23, 2024. (5:30am IST). If your PRs have already been approved, request a re-review after fixing the conflicts and refactoring to the new |
@Cioppolo14, sorry for the delay (bcuz of exams). |
fixed lint issue |
The PR merging freeze is lifted.
Background:
|
@pranshugupta54 Please fix the failing tests. |
Yes, fixing it completely for userType |
…es to MemberDetail.module.css, and update Queries.ts and mutations.ts
@palisadoes, please check this. Fixed everything,
Failing checks:
|
e78d952
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Admin -> User Profile -> Re-design
Issue Number:
Fixes #1615
Screenshot:
Other information
NOTE: