Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Profile Update Not Working on Admin Portal #1508" #1698

Closed
wants to merge 21 commits into from
Closed

Fix "Profile Update Not Working on Admin Portal #1508" #1698

wants to merge 21 commits into from

Conversation

Shubh152
Copy link

What kind of change does this PR introduce?

bug-fix

Issue Number:

Fixes #1508

Did you add tests for your changes?

Yes

Snapshots/Videos:

If relevant, did you update the documentation?

Summary
This pull request makes relevant changes in the admin repo for PalisadoesFoundation/talawa-api#1750

Does this PR introduce a breaking change?

No

Other information

Continued from #1573

Have you read the contributing guide?
Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@Shubh152 Shubh152 changed the title Feature req Fix "Profile Update Not Working on Admin Portal #1508" Mar 10, 2024
@Cioppolo14
Copy link

@Shubh152 Can you fix the failing test application check?

@pranshugupta54
Copy link
Member

pranshugupta54 commented Mar 10, 2024

@Cioppolo14, this should be automatically fixed in the new design of this page. PR #1615 / #1667

@Cioppolo14
Copy link

I believe this test needs to pass before we can move the PR forward in the review process.

@Shubh152
Copy link
Author

Shubh152 commented Mar 12, 2024

The Test failure was unexpected as I have not made any changes that could have caused this. Anyway if this is resolved in PR #1615 / #1667 as claimed by @pranshugupta54, then we should close this PR.

@Shubh152
Copy link
Author

Also the corresponding issue must be closed.

@palisadoes palisadoes closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants