-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Profile Update Not Working on Admin Portal #1508" #1698
Conversation
This reverts commit afcd894.
This reverts commit ee9b3d1.
This reverts commit 1053a91.
…awa-admin into current-develop
…awa-admin into current-develop
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@Shubh152 Can you fix the failing test application check? |
@Cioppolo14, this should be automatically fixed in the new design of this page. PR #1615 / #1667 |
I believe this test needs to pass before we can move the PR forward in the review process. |
The Test failure was unexpected as I have not made any changes that could have caused this. Anyway if this is resolved in PR #1615 / #1667 as claimed by @pranshugupta54, then we should close this PR. |
Also the corresponding issue must be closed. |
What kind of change does this PR introduce?
bug-fix
Issue Number:
Fixes #1508
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
This pull request makes relevant changes in the admin repo for PalisadoesFoundation/talawa-api#1750
Does this PR introduce a breaking change?
No
Other information
Continued from #1573
Have you read the contributing guide?
Yes