Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin - Add support for Action Items #1462

Closed
meetulr opened this issue Jan 21, 2024 · 45 comments
Closed

Admin - Add support for Action Items #1462

meetulr opened this issue Jan 21, 2024 · 45 comments
Assignees

Comments

@meetulr
Copy link

meetulr commented Jan 21, 2024

Is your feature request related to a problem? Please describe.
Adding support for Action Items in talawa-admin.

Describe the solution you'd like

  1. A screen for action item categories on the org leftDrawer, through which we could create, edit and view all the categories.
  2. A screen for action items on the org leftDrawer, for similar crud functionalities. We could also add custom filter and search functionality for getting action items for a single category, assigned to a certain user, etc.
  3. A screen on the event dashboard for action items associated with that event (as was previously the case for event projects). Here also, aside from the basic crud, we could add filter search functionality like the one described above.

Additional context
It's a companion issue for this one in the api.

@meetulr
Copy link
Author

meetulr commented Jan 21, 2024

As mentioned, this is a companion issue for the one in the api.
And as discussed, it will also serve as an evaluation for the pr I opened for the corresponding issue.
Please assign it to me so that I can start working on it.

Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@meetulr
Copy link
Author

meetulr commented Jan 21, 2024

@palisadoes Please let me know if the solution I proposed is acceptable, and if anything else is required.

@meetulr meetulr changed the title Create support for Action Items Admin - Add support for Action Items Jan 21, 2024
@palisadoes
Copy link
Contributor

Layout

  1. Action Item CRUD (Organization wide), your suggestion is OK
  2. Action Item CRUD (Event specific), your suggestion is OK
  3. Category CRUD should be on the organization settings page, however we are doing some redesigns for it that will cause merge conflicts. Your suggestion is OK, and when the redesign work is complete we can rearrange things

Other

  1. Make sure your designs are in keeping with our design standards. The Figma file can be found here:
  2. We'll need your Figma designs to be added to the project's when you are done

@palisadoes
Copy link
Contributor

@rishav-jha-mech @aashimawadhwa This is an issue to watch. There will be some design modifications required.

@meetulr
Copy link
Author

meetulr commented Jan 21, 2024

Layout

  1. Action Item CRUD (Organization wide), your suggestion is OK
  2. Action Item CRUD (Event specific), your suggestion is OK
  3. Category CRUD should be on the organization settings page, however we are doing some redesigns for it that will cause merge conflicts. Your suggestion is OK, and when the redesign work is complete we can rearrange things

Other

  1. Make sure your designs are in keeping with our design standards. The Figma file can be found here:

  2. We'll need your Figma designs to be added to the project's when you are done

Could you please elaborate on that third point. Categories should be on the organization settings page? Could you direct me to the issue addressing the redesign that you mentioned.

Also, please assign me so that I can start working on it.
Thanks.

@palisadoes
Copy link
Contributor

@meetulr

  1. We will need to add your Figma page designs to our official Figma document
  2. Please plan for this

@palisadoes
Copy link
Contributor

This is the issue that will be modifying the Organization Settings page. Categories are going to be organization wide. Moving the CRUD for this to the settings page leaves the main left drawer for the most commonly accessed features.

@meetulr
Copy link
Author

meetulr commented Jan 22, 2024

Alright! Thank you.

@meetulr
Copy link
Author

meetulr commented Jan 26, 2024

@aashimawadhwa @rishav-jha-mech Where do we want action items on the event dashboard:
Screenshot (16)

Shall I put them below the details:
Screenshot (18)

I could add some designs in the details later.

@palisadoes
Copy link
Contributor

Access the volunteers via a button below this one.

image

@meetulr
Copy link
Author

meetulr commented Jan 27, 2024

Could you please clarify😅.
We need a custom sort and filter functionality for action items right? (Like that in the organizations list).

Would it be ok to keep the search bar and Action Item cards directly below the event details? Like Projects used to be? (To view all the action items, and perform operations on them directly from there).

@palisadoes
Copy link
Contributor

palisadoes commented Jan 27, 2024

Every button on this page is related to showing a different aspect of event detail. We need separate detail for action items.

The button on the screen should be below the box in my previous comment

What type of sorting and search were you planning on providing?

@meetulr
Copy link
Author

meetulr commented Jan 27, 2024

Yes, so everything related to action items should be inside a modal, accessible from the left drawer in the event options (below the check in registrants)?

About the search, I was thinking we should be able to sort the action items (latest/oldest). And, to be able to filter them, by actionItemCategoryId or status, for better monitoring and management.

Would that be ok?

@palisadoes
Copy link
Contributor

The API PR has been merged

@palisadoes
Copy link
Contributor

Yes, so everything related to action items should be inside a modal, accessible from the left drawer in the event options (below the check in registrants)?

About the search, I was thinking we should be able to sort the action items (latest/oldest). And, to be able to filter them, by actionItemCategoryId or assigneeId, for better monitoring and management.

Would that be ok?

I was thinking that for an event, the sort and search features won't be necessary as they would be rarely used. Then I realized that for general non-event activities there could be many items.

Your suggestion is OK. Please proceed.

@palisadoes
Copy link
Contributor

@meetulr

Your PR for the API was much too large. Dozens of files and thousands of lines of code. This issue will need to be split into at least 3 separate PRs.

  1. Category CRUD
  2. Non-Event Action Item CRUD
  3. Event Action Item CRUD

@meetulr
Copy link
Author

meetulr commented Jan 29, 2024

Yes, thank you! That would be more convenient for everyone.

@meetulr
Copy link
Author

meetulr commented Jan 29, 2024

Where do I put the section for action item category on the settings page?
orgSettings1
orgSettings2

@palisadoes
Copy link
Contributor

  1. Consider a new left drawer for settings
    1. One button for general settings like what we have
    2. Another button for creating Action Item categories
  2. Have a back arrow to get back to the main menu
  3. The left drawer title must be Settings, not Menu

@meetulr
Copy link
Author

meetulr commented Jan 29, 2024

So, a new leftDrawer for the orgSettings screen (like the event leftDrawer for event dashboard)? This leftDrawer would contain options like event options in the event leftDrawer.

Here we would currently have three options:

  1. General settings.
  2. Action Item Categories.
  3. Back arrow to the main menu.

Is that what you mean?

By the way, are we going to have some other organization specific things like action item categories that would be added to the options of this new left drawer?

@palisadoes
Copy link
Contributor

  1. Yes, there will be new organization specific parameters to edit.
  2. Yes, like the event details
  3. In your original note you said that "Action Item Categories have only it's name to show". You could consider a misc button which goes to a screen with tabbed sections, like the user profile pages design in the Admin figma here. One tab would cover Action Item categories.
    1. https://docs.talawa.io/docs/design/ux/ux-design-system

@meetulr
Copy link
Author

meetulr commented Jan 29, 2024

Yes, I like the tabs approach:

tabs-sample.mp4

We could just add more tabs here for upcoming organization specific features.
It's just for the tabs sample. I would improve on the categories design. And add modals for create and edit functionalities.

Is that ok?

@palisadoes
Copy link
Contributor

The tabs need to follow our design scheme with a white background, grey borders like in the Figma document.

image

@meetulr
Copy link
Author

meetulr commented Jan 30, 2024

Yes, I'll make the design adjustments. Thank you.

@palisadoes
Copy link
Contributor

This looks good. Please submit your PR

@meetulr
Copy link
Author

meetulr commented Jan 30, 2024

Alright, I'll add the tests and open a pr tomorrow.

@meetulr
Copy link
Author

meetulr commented Feb 3, 2024

How's this design for action items (organization wide)
Action Item

@palisadoes
Copy link
Contributor

  1. One row per entry. It's more intuitive.
  2. We are going to have to migrate to that approach across the app

@meetulr
Copy link
Author

meetulr commented Feb 4, 2024

actionItems

@palisadoes
Copy link
Contributor

  1. This looks OK.
  2. Can you provide the figma link to this designs so that we can add to our official one? We'll probably create issues to fine tune them later.
    1. @aashimawadhwa @rishav-jha-mech take note

@meetulr
Copy link
Author

meetulr commented Feb 11, 2024

  1. Category CRUD
  2. Non-Event Action Item CRUD
  3. Event Action Item CRUD

@palisadoes part 2 and part 3 of this issue are still remaining.

@meetulr
Copy link
Author

meetulr commented Feb 11, 2024

  1. This looks OK.

  2. Can you provide the figma link to this designs so that we can add to our official one? We'll probably create issues to fine tune them later.

    1. @aashimawadhwa @rishav-jha-mech take note

Oh and I'm sorry I missed this comment. I'm learning figma. I'll make the designs and share the links😅.

@palisadoes palisadoes reopened this Feb 11, 2024
@palisadoes
Copy link
Contributor

palisadoes commented Feb 11, 2024

  1. Did you see that your PR didn't pass the tests after merging?
    1. https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/7863549480/job/21454284769#step:6:1127
  2. Please resubmit to fix the apparent edge case

@meetulr
Copy link
Author

meetulr commented Feb 11, 2024

Ok, I'll have to look into it.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 22, 2024
@meetulr
Copy link
Author

meetulr commented Feb 22, 2024

A pr is up for review #1596, after this, one last pr would be required for event dashboard. Then the basic functionalities would be done.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 23, 2024
@meetulr
Copy link
Author

meetulr commented Feb 26, 2024

@palisadoes what will the home screen of the Event Dashboard ultimately display?

Currently, it only shows basic event information.
Event-specific details, such as registrants, check-in registrants, action items, and event stats, are all accessed through the left drawer in the form of modals.

@palisadoes
Copy link
Contributor

@palisadoes what will the home screen of the Event Dashboard ultimately display?

Currently, it only shows basic event information. Event-specific details, such as registrants, check-in registrants, action items, and event stats, are all accessed through the left drawer in the form of modals.

We'll be creating an issue for this via either @aashimawadhwa and/or @rishav-jha-mech

@meetulr
Copy link
Author

meetulr commented Feb 27, 2024

@palisadoes what will the home screen of the Event Dashboard ultimately display?
Currently, it only shows basic event information. Event-specific details, such as registrants, check-in registrants, action items, and event stats, are all accessed through the left drawer in the form of modals.

We'll be creating an issue for this via either @aashimawadhwa and/or @rishav-jha-mech

I'm sorry, I don't understand😅. I wanted to know what the home screen would eventually show.
As all the event-specifics are currently in the left drawer.
Is it not planned yet?

@palisadoes
Copy link
Contributor

  1. Understood. Yes, the default screen is bare.
  2. We're working on a design

@palisadoes
Copy link
Contributor

We'll need issues for the API and Admin to cover action items for recurring events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants