-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin - Add support for Action Items #1462
Comments
Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues. |
@palisadoes Please let me know if the solution I proposed is acceptable, and if anything else is required. |
Layout
Other
|
@rishav-jha-mech @aashimawadhwa This is an issue to watch. There will be some design modifications required. |
Could you please elaborate on that third point. Categories should be on the organization settings page? Could you direct me to the issue addressing the redesign that you mentioned. Also, please assign me so that I can start working on it. |
|
This is the issue that will be modifying the Organization Settings page. Categories are going to be organization wide. Moving the CRUD for this to the settings page leaves the main left drawer for the most commonly accessed features. |
Alright! Thank you. |
@aashimawadhwa @rishav-jha-mech Where do we want action items on the event dashboard: Shall I put them below the details: I could add some designs in the details later. |
Could you please clarify😅. Would it be ok to keep the search bar and Action Item cards directly below the event details? Like Projects used to be? (To view all the action items, and perform operations on them directly from there). |
Every button on this page is related to showing a different aspect of event detail. We need separate detail for action items. The button on the screen should be below the box in my previous comment What type of sorting and search were you planning on providing? |
Yes, so everything related to action items should be inside a modal, accessible from the left drawer in the event options (below the check in registrants)? About the search, I was thinking we should be able to sort the action items (latest/oldest). And, to be able to filter them, by actionItemCategoryId or status, for better monitoring and management. Would that be ok? |
The API PR has been merged |
I was thinking that for an event, the sort and search features won't be necessary as they would be rarely used. Then I realized that for general non-event activities there could be many items. Your suggestion is OK. Please proceed. |
Your PR for the API was much too large. Dozens of files and thousands of lines of code. This issue will need to be split into at least 3 separate PRs.
|
Yes, thank you! That would be more convenient for everyone. |
|
So, a new leftDrawer for the orgSettings screen (like the event leftDrawer for event dashboard)? This leftDrawer would contain options like event options in the event leftDrawer. Here we would currently have three options:
Is that what you mean? By the way, are we going to have some other organization specific things like action item categories that would be added to the options of this new left drawer? |
|
Yes, I like the tabs approach: tabs-sample.mp4We could just add more tabs here for upcoming organization specific features. Is that ok? |
The tabs need to follow our design scheme with a white background, grey borders like in the Figma document. |
Yes, I'll make the design adjustments. Thank you. |
This looks good. Please submit your PR |
Alright, I'll add the tests and open a pr tomorrow. |
|
|
@palisadoes part 2 and part 3 of this issue are still remaining. |
Oh and I'm sorry I missed this comment. I'm learning figma. I'll make the designs and share the links😅. |
|
Ok, I'll have to look into it. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
A pr is up for review #1596, after this, one last pr would be required for event dashboard. Then the basic functionalities would be done. |
@palisadoes what will the home screen of the Event Dashboard ultimately display? Currently, it only shows basic event information. |
We'll be creating an issue for this via either @aashimawadhwa and/or @rishav-jha-mech |
I'm sorry, I don't understand😅. I wanted to know what the home screen would eventually show. |
|
We'll need issues for the API and Admin to cover action items for recurring events |
Is your feature request related to a problem? Please describe.
Adding support for Action Items in talawa-admin.
Describe the solution you'd like
Additional context
It's a companion issue for this one in the api.
The text was updated successfully, but these errors were encountered: