Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Support for Action Item Category #1578

Merged
merged 17 commits into from
Feb 11, 2024

Conversation

meetulr
Copy link

@meetulr meetulr commented Feb 11, 2024

Issue Number:

Fixes #1462

Did you add tests for your changes?

Yes

Demo
On large screens:

On.large.screens.mp4

On small screens:

On.small.screens.mp4

Additional Context

This is to address the test that was failing after merging this pr #1522.

Next PR: #1596

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a165ee0) 96.65% compared to head (e80d34a) 96.74%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1578      +/-   ##
===========================================
+ Coverage    96.65%   96.74%   +0.09%     
===========================================
  Files          136      138       +2     
  Lines         3587     3687     +100     
  Branches      1101     1125      +24     
===========================================
+ Hits          3467     3567     +100     
  Misses         114      114              
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes merged commit 558c475 into PalisadoesFoundation:develop Feb 11, 2024
9 of 10 checks passed
@meetulr meetulr changed the title Action item category feat: Add Support for Action Item Category Feb 12, 2024
chintu-777 added a commit to chintu-777/talawa-admin that referenced this pull request Feb 16, 2024
@meetulr meetulr deleted the action-item-category branch February 20, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants