-
-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Support for Action Item Category #1578
feat: Add Support for Action Item Category #1578
Conversation
…awa-admin into action-item-category
This reverts commit 13a638b.
This reverts commit 4293627.
…awa-admin into action-item-category
This reverts commit bddc63d.
…awa-admin into action-item-category
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1578 +/- ##
===========================================
+ Coverage 96.65% 96.74% +0.09%
===========================================
Files 136 138 +2
Lines 3587 3687 +100
Branches 1101 1125 +24
===========================================
+ Hits 3467 3567 +100
Misses 114 114
Partials 6 6 ☔ View full report in Codecov by Sentry. |
558c475
into
PalisadoesFoundation:develop
This reverts commit 558c475.
Issue Number:
Fixes #1462
Did you add tests for your changes?
Yes
Demo
On large screens:
On.large.screens.mp4
On small screens:
On.small.screens.mp4
Additional Context
This is to address the test that was failing after merging this pr #1522.
Next PR: #1596