-
-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Action Items #1648
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
I've had fun implementing this. Let me know if any changes are required, or if I've missed anything. |
Just to confirm, did you implement Action Items related to Events and to Users independent of events? |
I only restricted the assignment of an action item to organization members. That means even if the action item is associated with an event, it could be assigned to a user regardless them not being involved with the event, they just have to be a member of the organization. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1648 +/- ##
===========================================
+ Coverage 98.17% 98.37% +0.19%
===========================================
Files 184 225 +41
Lines 10767 13630 +2863
Branches 835 1141 +306
===========================================
+ Hits 10571 13409 +2838
- Misses 186 189 +3
- Partials 10 32 +22 ☔ View full report in Codecov by Sentry. |
Please review |
Let me know if there are any redundancies, with any queries, or in mongoose schemas. |
|
I've made all the requested changes. |
This is ready for review. Please take a look. |
This is a sandbox demo for the changes I made:
actionItemCategory.mp4
actionItems.mp4
cascadeDeletion.mp4 |
I'll test it out and let you know. |
@xoldyckk The frontend for this is now in development, any changes made/required here would have an impact there too. Please take a look!😅 |
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor suggestion.
Thank you! I've made the change, and I'll keep that in mind. |
@EshaanAgg please review the updates |
de4debc
into
PalisadoesFoundation:develop
Fixes #1595
Did you add tests for your changes?
Yes
Summary
This pull request introduces the following changes:
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes