Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y audit 7-1 #2695

Merged
merged 3 commits into from
Oct 1, 2024
+12 −23
Merged

Fix a11y audit 7-1 #2695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75814f1
Fix tarteaucitron design and display
louismaximepiton Aug 20, 2024
19f8041
Merge branch 'main' into main-lmp-a11y-7-1-label-tarteaucitron
hannahiss Sep 12, 2024
c7ec210
Merge branch 'main' into main-lmp-a11y-7-1-label-tarteaucitron
julien-deramond Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions site/assets/js/tac.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
const tac = document.getElementById('tarteaucitron')

tac.querySelectorAll('.tarteaucitronAllow').forEach(button => {
button.classList.add('btn', 'btn-sm', 'btn-success', 'my-2', 'my-lg-0')
button.classList.add('btn', 'btn-sm', 'btn-success')
button.innerHTML = tarteaucitron.lang.allowAll
})

tac.querySelectorAll('.tarteaucitronDeny').forEach(button => {
button.classList.add('btn', 'btn-sm', 'btn-danger', 'my-2', 'my-lg-0', 'ms-lg-2')
button.classList.add('btn', 'btn-sm', 'btn-danger', 'mt-1', 'mt-md-0', 'ms-md-3')
button.innerHTML = tarteaucitron.lang.denyAll
})

Expand Down Expand Up @@ -79,7 +79,7 @@
const toggle = document
.createRange()
.createContextualFragment(
`<div class="form-check form-switch my-2 my-lg-0"><input class="form-check-input ms-0" type="checkbox" id="googletagmanagerAllowed" aria-describedby="tacCLgoogletagmanager" onchange="${choiceEvent}"${((document.cookie.match(/^(?:.*;)?\s*cookie-consent\s*=\s*([^;]+)(?:.*)?$/) || [null])[1].match('!googletagmanager=true') ? 'checked' : '')}><label class="form-check-label visually-hidden" for="googletagmanagerAllowed">Google Tag Manager</label><input id="googletagmanagerDenied" class="d-none"></div>`
`<div class="form-check form-switch ps-0"><input class="form-check-input ms-0" type="checkbox" id="googletagmanagerAllowed" aria-describedby="tacCLgoogletagmanager" onchange="${choiceEvent}"${((document.cookie.match(/^(?:.*;)?\s*cookie-consent\s*=\s*([^;]+)(?:.*)?$/) || [null])[1].match('!googletagmanager=true') ? 'checked' : '')}><label class="form-check-label visually-hidden" for="googletagmanagerAllowed">Google Tag Manager</label><input id="googletagmanagerDenied" class="d-none"></div>`
)
ask.innerHTML = ''
ask.append(toggle)
Expand Down
29 changes: 9 additions & 20 deletions site/assets/scss/_tarteaucitron.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
z-index: $zindex-modal;
display: none;
width: 100%;
max-width: $modal-md;
padding: $modal-content-padding;
background-color: $modal-content-bg;
background-clip: padding-box;
Expand All @@ -15,23 +16,6 @@
font-weight: $font-weight-bold;
color: $modal-content-color;
}

@include media-breakpoint-up(sm) {
max-width: $modal-sm;
margin: $modal-dialog-margin-y-sm-up auto;
}

@include media-breakpoint-up(md) {
max-width: $modal-md;
}

@include media-breakpoint-up(lg) {
max-width: $modal-lg * 1.125;
}

@include media-breakpoint-up(xl) {
max-width: $modal-xl * 1.25;
}
}

@include tac("Root") {
Expand Down Expand Up @@ -120,23 +104,28 @@
}

@include tac("Name", true) {
float: left;
font-size: $font-size-sm;
color: var(--bs-secondary-color);
}

@include tac("Ask", true) {
float: right;
display: flex;
flex-direction: column;
margin-top: $spacer * .5;

@include media-breakpoint-up(md) {
flex-direction: row;
}
}

@include tac("Line", true) {
margin-bottom: $spacer;
overflow: visible;
@include clearfix();
}

@include tac("MainLine", true) {
padding-bottom: $spacer;
margin-bottom: $spacer;
border-bottom: $modal-content-border-width solid $modal-content-border-color;
}

Expand Down
Loading