Fix a11y audit 7-1

[louismaximepiton]

Related issues

#2667 7-1

Description

• Rearrange the tarteaucitron modal structure.

Motivation & Context

Read the related issue. The switch was too far away from the label.

Types of change

• Bug fix (non-breaking which fixes an issue)

Live previews

• https://deploy-preview-2695--boosted.netlify.app/docs/about/cookies

[netlify]

✅ Deploy Preview for boosted ready!

Name	Link
🔨 Latest commit	c7ec210
🔍 Latest deploy log	https://app.netlify.com/sites/boosted/deploys/66fb8db119b9c50008a93d0a
😎 Deploy Preview	https://deploy-preview-2695--boosted.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[hannahiss]

LGTM as you say 😄

[julien-deramond]

It was not seen in the accessibility audit, but with the new tarteaucitron version, there's a "Save" button. Don't you think there's an issue with the focus order, where the "Save" button is focused after the footer link? Can be tackled in another PR.
/cc @hannahiss

[hannahiss]

It was not seen in the accessibility audit, but with the new tarteaucitron version, there's a "Save" button. Don't you think there's an issue with the focus order, where the "Save" button is focused after the footer link? Can be tackled in another PR. /cc @hannahiss

Yes, the order is strange... I vote for another PR 😉

[julien-deramond]

It was not seen in the accessibility audit, but with the new tarteaucitron version, there's a "Save" button. Don't you think there's an issue with the focus order, where the "Save" button is focused after the footer link? Can be tackled in another PR. /cc @hannahiss

Yes, the order is strange... I vote for another PR 😉

Added to the audit issue as a bonus task since it can be a problem during the next one.

[louismaximepiton]

It was not seen in the accessibility audit, but with the new tarteaucitron version, there's a "Save" button. Don't you think there's an issue with the focus order, where the "Save" button is focused after the footer link? Can be tackled in another PR. /cc @hannahiss

It seems like moving the link after the Save button breaks, because of the tarteaucitron focus trap. If the link is moved after the button manually, you can't focus it anymore (even doing it manually). I'd say it's not easily feasible.

[julien-deramond]

It seems like moving the link after the Save button breaks, because of the tarteaucitron focus trap. If the link is moved after the button manually, you can't focus it anymore (even doing it manually). I'd say it's not easily feasible.

In your opinion, we abandon this modification?

[louismaximepiton]

We can abandon this until AmauriC/tarteaucitron.js#1280 is tackled.