-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add and hide callout from the documentation #2625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
v5
docs
Improvements or additions to documentation
enhancement
labels
Jul 16, 2024
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
changed the title
[OUDS] Docs: Add and hide callout from the documentation
Docs: Add and hide callout from the documentation
Jul 16, 2024
louismaximepiton
force-pushed
the
main-lmp-add-design-callouts-in-docs
branch
from
July 17, 2024 14:11
4f2013b
to
fbffa84
Compare
julien-deramond
force-pushed
the
main-lmp-add-design-callouts-in-docs
branch
from
July 18, 2024 04:59
fbffa84
to
f84d102
Compare
- Change wording and add various design callouts about the incompatibility with ODS - Add missing examples from Bootstrap within `<details><summary>` Co-authored by: Isabelle Chanclou <[email protected]> Co-authored by: Hannah Issermann <[email protected]> Co-authored by: Julien Déramond <[email protected]>
julien-deramond
force-pushed
the
main-lmp-add-design-callouts-in-docs
branch
from
July 18, 2024 05:04
f84d102
to
6538b4e
Compare
This was referenced Jul 18, 2024
julien-deramond
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Supersedes #1614 and #2001.
Closes #2128.
Description
Links have a component or guidelines word inside to let people know that the link goes on Boosted or the DSM.
If one example is fine, it should appear before the details/summary.
Use
See Bootstrap example(s) that are incompatible with Orange Design System.
sentence in the summary.Use small sentences to explain why the example isn't good.
Motivation & Context
Before long term maintenance.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge