-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cards : fix design + add design callout messages #2001
Conversation
Signed-off-by: Isabelle Chanclou <[email protected]>
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Isabelle Chanclou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some few comments.
Signed-off-by: Isabelle Chanclou <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Thanks a lot for this work. It has been gathered and merged with other modifications in #2625. All participants of this PR will be mentioned as co-authors in it. |
Related issues
Closes #1992
Linked to #1199
Description
After a design review of all the card variants, the purpose of this PR is to fix the design of some variants in order to make them aligned on the Orange design specifications and to add design callout messages before the variants that should not be used because not suitable in Orange design system.
Motivation & Context
The goal here is to offer in Boosted more guidance on what can be used or not in Orange apps and to reduce discrepancies between Boosted documentation and the Orange design system one.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge