Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star rating dark mode #2275

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Star rating dark mode #2275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,9 +1179,10 @@ $form-star-size: 1.5625rem !default;
$form-star-size-sm: 1.25rem !default;
$form-star-margin-between: -.125rem !default;

$form-star-rating-checked-color: $accessible-orange !default;
$form-star-rating-unchecked-color: $gray-700 !default;
$form-star-rating-hover-color: $black !default;
$form-star-rating-checked-color: var(--#{$prefix}link-hover-color) !default;
$form-star-rating-unchecked-color: var(--#{$prefix}secondary-color) !default;
$form-star-rating-hover-color: var(--#{$prefix}highlight-bg) !default;
$form-star-rating-disabled-color: var(--#{$prefix}border-color-translucent) !default;

$form-star-rating-checked-icon: escape-svg(url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 25 25'><path fill='#000' stroke='#000' d='m12.5 4.523 2.016 6.227 6.542-.005-5.296 3.843 2.027 6.224L12.5 16.96l-5.289 3.852 2.027-6.224-5.296-3.843 6.542.005L12.5 4.523Z'/></svg>")) !default;
$form-star-rating-unchecked-icon: escape-svg(url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 25 25'><path fill='transparent' stroke='#000' d='m12.5 4.523 2.016 6.227 6.542-.005-5.296 3.843 2.027 6.224L12.5 16.96l-5.289 3.852 2.027-6.224-5.296-3.843 6.542.005L12.5 4.523Z'/></svg>")) !default;
Expand Down
4 changes: 2 additions & 2 deletions scss/forms/_star-rating.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

&:disabled {
pointer-events: none;
--#{$prefix}star-rating-checked-color: var(--#{$prefix}border-color-translucent);
--#{$prefix}star-rating-unchecked-color: var(--#{$prefix}border-color-translucent);
--#{$prefix}star-rating-checked-color: #{$form-star-rating-disabled-color};
--#{$prefix}star-rating-unchecked-color: #{$form-star-rating-disabled-color};
}

> label {
Expand Down
149 changes: 125 additions & 24 deletions site/content/docs/5.3/dark-mode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,11 @@ sitemap_exclude: true
</div>
</div>

## Accordions
## Components

### No theme
### Accordions

#### No theme

<div class="border border-tertiary p-3">
<div class="accordion" id="accordionExample1">
Expand Down Expand Up @@ -126,7 +128,7 @@ sitemap_exclude: true
</div>
</div>

### Dark theme on container
#### Dark theme on container

Using bg-body

Expand Down Expand Up @@ -169,7 +171,7 @@ Using bg-body
</div>
</div>

### Light theme on container
#### Light theme on container

Using bg-body

Expand Down Expand Up @@ -212,7 +214,7 @@ Using bg-body
</div>
</div>

### Dark theme on component
#### Dark theme on component

<div class="border border-tertiary p-3" style="background-color: #282d55">
<div class="accordion" id="accordionExample6" data-bs-theme="dark">
Expand Down Expand Up @@ -253,7 +255,7 @@ Using bg-body
</div>
</div>

### Light theme on component
#### Light theme on component

<div class="border border-tertiary p-3" style="background-color: #b5e8f7">
<div class="accordion" id="accordionExample7" data-bs-theme="light">
Expand Down Expand Up @@ -294,9 +296,9 @@ Using bg-body
</div>
</div>

## Alerts
### Alerts

### No theme
#### No theme

<div class="border border-tertiary p-3">
<div class="alert alert-success" role="alert">
Expand All @@ -317,7 +319,7 @@ Using bg-body
</div>
</div>

### Dark theme on container
#### Dark theme on container

Using bg-body

Expand All @@ -340,7 +342,7 @@ Using bg-body
</div>
</div>

### Light theme on container
#### Light theme on container

Using bg-body

Expand All @@ -363,7 +365,7 @@ Using bg-body
</div>
</div>

### Dark theme on component
#### Dark theme on component

<div class="border border-tertiary p-3" style="background-color: #282d55">
<div class="alert alert-success bg-body" role="alert" data-bs-theme="dark">
Expand All @@ -384,7 +386,7 @@ Using bg-body
</div>
</div>

### Light theme on component
#### Light theme on component

<div class="border border-tertiary p-3" style="background-color: #b5e8f7">
<div class="alert alert-success bg-body" role="alert" data-bs-theme="light">
Expand All @@ -405,9 +407,9 @@ Using bg-body
</div>
</div>

## Stepped process
### Stepped process

### No theme
#### No theme

<div class="border border-tertiary p-3">
<nav class="stepped-process" aria-label="Checkout process">
Expand All @@ -432,7 +434,7 @@ Using bg-body
</nav>
</div>

### Dark theme on container
#### Dark theme on container

Using bg-body

Expand All @@ -459,7 +461,7 @@ Using bg-body
</nav>
</div>

### Light theme on container
#### Light theme on container

Using bg-body

Expand All @@ -486,7 +488,7 @@ Using bg-body
</nav>
</div>

### Dark theme on component
#### Dark theme on component

<div class="border border-tertiary p-3" style="background-color: #282d55;">
<nav class="stepped-process" aria-label="Checkout process" data-bs-theme="dark" style="--bs-stepped-process-bg: #282d55;">
Expand All @@ -511,7 +513,7 @@ Using bg-body
</nav>
</div>

### Light theme on component
#### Light theme on component

<div class="border border-tertiary p-3" style="background-color: #b5e8f7">
<nav class="stepped-process" aria-label="Checkout process" data-bs-theme="light" style="--bs-stepped-process-bg: #b5e8f7;">
Expand All @@ -536,9 +538,9 @@ Using bg-body
</nav>
</div>

## Local navigation
### Local navigation

### No theme
#### No theme
<div class="border border-tertiary p-3">
<nav class="local-nav" aria-label="Basic local navigation" data-bs-theme="dark">
<button class="local-nav-button collapsed d-lg-none" type="button" data-bs-toggle="collapse" data-bs-target="#collapseLocalNav1" aria-expanded="false" aria-controls="collapseLocalNav1">
Expand All @@ -557,7 +559,7 @@ Using bg-body
</nav>
</div>

### Dark theme on container
#### Dark theme on container

Using bg-body

Expand All @@ -579,7 +581,7 @@ Using bg-body
</nav>
</div>

### Light theme on container
#### Light theme on container

Using bg-body

Expand All @@ -601,7 +603,7 @@ Using bg-body
</nav>
</div>

### Dark theme on component
#### Dark theme on component

<div class="border border-tertiary p-3" style="background-color: #282d55">
<nav class="local-nav" aria-label="Basic local navigation" data-bs-theme="dark">
Expand All @@ -621,7 +623,7 @@ Using bg-body
</nav>
</div>

### Light theme on component
#### Light theme on component

<div class="border border-tertiary p-3" style="background-color: #b5e8f7">
<nav class="local-nav" aria-label="Basic local navigation" data-bs-theme="light">
Expand All @@ -640,3 +642,102 @@ Using bg-body
</div>
</nav>
</div>


## Forms

### Star rating

#### No theme

<div class="border border-tertiary p-3">
<form><fieldset class="star-rating">
<legend class="visually-hidden">Results relevance</legend>
<input type="radio" id="terrible1" name="rating" value="1" class="visually-hidden">
<label for="terrible1" title="Terrible"><span class="visually-hidden">Terrible</span></label>
<input type="radio" id="bad1" name="rating" value="2" class="visually-hidden">
<label for="bad1" title="Bad"><span class="visually-hidden">Bad</span></label>
<input type="radio" id="mixed1" name="rating" value="3" class="visually-hidden">
<label for="mixed1" title="Mixed"><span class="visually-hidden">Mixed</span></label>
<input type="radio" id="good1" name="rating" value="4" class="visually-hidden" checked>
<label for="good1" title="Good"><span class="visually-hidden">Good</span></label>
<input type="radio" id="excellent1" name="rating" value="5" class="visually-hidden">
<label for="excellent1" title="Excellent"><span class="visually-hidden">Excellent</span></label>
</fieldset></form>
</div>

#### Dark theme on container

Using bg-body

<div class="border border-tertiary p-3 bg-body" data-bs-theme="dark">
<form><fieldset class="star-rating">
<legend class="visually-hidden">Results relevance</legend>
<input type="radio" id="terrible2" name="rating" value="1" class="visually-hidden">
<label for="terrible2" title="Terrible"><span class="visually-hidden">Terrible</span></label>
<input type="radio" id="bad2" name="rating" value="2" class="visually-hidden">
<label for="bad2" title="Bad"><span class="visually-hidden">Bad</span></label>
<input type="radio" id="mixed2" name="rating" value="3" class="visually-hidden">
<label for="mixed2" title="Mixed"><span class="visually-hidden">Mixed</span></label>
<input type="radio" id="good2" name="rating" value="4" class="visually-hidden" checked>
<label for="good2" title="Good"><span class="visually-hidden">Good</span></label>
<input type="radio" id="excellent2" name="rating" value="5" class="visually-hidden">
<label for="excellent2" title="Excellent"><span class="visually-hidden">Excellent</span></label>
</fieldset></form>
</div>

#### Light theme on container

Using bg-body

<div class="border border-tertiary p-3 bg-body" data-bs-theme="light">
<form><fieldset class="star-rating">
<legend class="visually-hidden">Results relevance</legend>
<input type="radio" id="terrible3" name="rating" value="1" class="visually-hidden">
<label for="terrible3" title="Terrible"><span class="visually-hidden">Terrible</span></label>
<input type="radio" id="bad3" name="rating" value="2" class="visually-hidden">
<label for="bad3" title="Bad"><span class="visually-hidden">Bad</span></label>
<input type="radio" id="mixed3" name="rating" value="3" class="visually-hidden">
<label for="mixed3" title="Mixed"><span class="visually-hidden">Mixed</span></label>
<input type="radio" id="good3" name="rating" value="4" class="visually-hidden" checked>
<label for="good3" title="Good"><span class="visually-hidden">Good</span></label>
<input type="radio" id="excellent3" name="rating" value="5" class="visually-hidden">
<label for="excellent3" title="Excellent"><span class="visually-hidden">Excellent</span></label>
</fieldset></form>
</div>

#### Dark theme on component

<div class="border border-tertiary p-3" style="background-color: #282d55;">
<form><fieldset class="star-rating" data-bs-theme="dark">
<legend class="visually-hidden">Results relevance</legend>
<input type="radio" id="terrible4" name="rating" value="1" class="visually-hidden">
<label for="terrible4" title="Terrible"><span class="visually-hidden">Terrible</span></label>
<input type="radio" id="bad4" name="rating" value="2" class="visually-hidden">
<label for="bad4" title="Bad"><span class="visually-hidden">Bad</span></label>
<input type="radio" id="mixed4" name="rating" value="3" class="visually-hidden">
<label for="mixed4" title="Mixed"><span class="visually-hidden">Mixed</span></label>
<input type="radio" id="good4" name="rating" value="4" class="visually-hidden" checked>
<label for="good4" title="Good"><span class="visually-hidden">Good</span></label>
<input type="radio" id="excellent4" name="rating" value="5" class="visually-hidden">
<label for="excellent4" title="Excellent"><span class="visually-hidden">Excellent</span></label>
</fieldset></form>
</div>

#### Light theme on component

<div class="border border-tertiary p-3" style="background-color: #b5e8f7">
<form><fieldset class="star-rating" data-bs-theme="light">
<legend class="visually-hidden">Results relevance</legend>
<input type="radio" id="terrible5" name="rating" value="1" class="visually-hidden">
<label for="terrible5" title="Terrible"><span class="visually-hidden">Terrible</span></label>
<input type="radio" id="bad5" name="rating" value="2" class="visually-hidden">
<label for="bad5" title="Bad"><span class="visually-hidden">Bad</span></label>
<input type="radio" id="mixed5" name="rating" value="3" class="visually-hidden">
<label for="mixed5" title="Mixed"><span class="visually-hidden">Mixed</span></label>
<input type="radio" id="good5" name="rating" value="4" class="visually-hidden" checked>
<label for="good5" title="Good"><span class="visually-hidden">Good</span></label>
<input type="radio" id="excellent5" name="rating" value="5" class="visually-hidden">
<label for="excellent5" title="Excellent"><span class="visually-hidden">Excellent</span></label>
</fieldset></form>
</div>