Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star rating dark mode #2275

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 3, 2023

Description

Star rating in dark mode, by using existing and one new Sass vars :

Sass var Previous value New value
$form-star-rating-checked-color $accessible-orange var(--#{$prefix}link-hover-color)
$form-star-rating-unchecked-color $gray-700 var(--#{$prefix}secondary-color)
$form-star-rating-hover-color $black var(--#{$prefix}highlight-bg)
$form-star-rating-disabled-color ⚠️ - var(--#{$prefix}border-color-translucent)

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 3, 2023
@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 175e4a9
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/651bf4109a975e000813a64a
😎 Deploy Preview https://deploy-preview-2275--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond self-requested a review October 3, 2023 11:08
Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julien-deramond julien-deramond mentioned this pull request Oct 3, 2023
@julien-deramond julien-deramond merged commit 56a39e5 into main-jd-dark-mode Oct 3, 2023
16 checks passed
@julien-deramond julien-deramond deleted the main-lmp-star-rating-dark branch October 3, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants