11.0 fix filestore perms #15
Conversation
|
This for the new car dealership project? |
Yes, however it's beneficial for any Odoo 11 which is based on |
opusvl-entrypoint.py
Outdated
|
|
||
| print("/entrypoint.sh {}".format(arglist), file=sys.stderr) | ||
| # Only set the uid to Odoo if we are in fact running Odoo | ||
| # and not a custom command with docker-compose run ... |
There was a problem hiding this comment.
I think if running_odoo: already says this.
opusvl-entrypoint.py
Outdated
| # and not a custom command with docker-compose run ... | ||
| print >>sys.stderr, "Changing uid to odoo uid: %s" %odoo_uid | ||
| os.setuid(odoo_uid) | ||
| print >>sys.stderr, "/entrypoint.sh {}".format(arglist) |
There was a problem hiding this comment.
I'd sooner stick with the function form of print().
Stick before all the other imports if you need to support python2:
from __future__ import print_function
Besides the statement form won't work in Python 3 anyway.
|
Oh @PeterAlabaster I also suggest adding to the README about the change, to say that users might have to explicitly use |
|
Perhaps we should be versioning these so breaking changes like this have a version number bump at the third level (e.g. We could freeze the two-level ones where they currently are and use three-level or four-level docker tags in our FROM clauses from this point on. |
Dockerfile
Outdated
| ONBUILD USER root | ||
| ONBUILD COPY ./addon-bundles/ /mnt/extra-addons-bundles/ | ||
| ONBUILD RUN chmod -R u=rwX,go=rX /mnt/extra-addons-bundles | ||
| ONBUILD COPY ./requirements.txt /root/ | ||
| ONBUILD RUN pip3 install -r /root/requirements.txt | ||
| ONBUILD USER odoo | ||
| ONBUILD RUN pip3 install -r /root/requirements.txt |
There was a problem hiding this comment.
Could you add a trailing newline please?
Fixes #14 for
11.0, not for12.0(that will need a seperate PR)