Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning odoo custom images #16

Open
Nick-OpusVL opened this issue Oct 17, 2019 · 8 comments
Open

Versioning odoo custom images #16

Nick-OpusVL opened this issue Oct 17, 2019 · 8 comments

Comments

@Nick-OpusVL
Copy link
Contributor

Perhaps we should be versioning these so breaking changes like this have a version number bump at the third level (e.g. 11.0.2.9 -> 11.0.3.0) and non-breaking changes at the fourth (e.g. 11.0.3.0 -> 11.0.3.1)

Originally posted by @Nick-OpusVL in #15 (comment)

@Nick-OpusVL
Copy link
Contributor Author

Purpose: to make sure we can add features with breaking changes without breaking other projects until we want to.

@Nick-OpusVL Nick-OpusVL changed the title Perhaps we should be versioning these so breaking changes like this have a version number bump at the third level (e.g. 11.0.2.9 -> 11.0.3.0) and non-breaking changes at the fourth (e.g. 11.0.3.0 -> 11.0.3.1) Versioning odoo custom images Oct 17, 2019
@PeterAlabaster
Copy link

Do you mean versioning at the branch level? (with branch name of 11.0.2.9 for example)?

@Nick-OpusVL
Copy link
Contributor Author

Nick-OpusVL commented Oct 17, 2019

Do you mean versioning at the branch level? (with branch name of 11.0.2.9 for example)?

11.0.2.9 would be a point-in-time tag, but it would be on the release branch 11.0.2

@Nick-OpusVL
Copy link
Contributor Author

This kind of change might even warrant a new repo (where this one would be frozen in time), so we didn't get confused about all the versions in the new one (there would be a disconnect between 11.0's relationship with 11.0.1 and 11.0.1's relationship with 11.0.1.1 otherwise, which could confuse us potentially with disastrous consequences otherwise).

@PeterAlabaster
Copy link

Sounds like a friday job when we have immunity from project owners :)

@Nick-OpusVL
Copy link
Contributor Author

Nick-OpusVL commented Oct 17, 2019

BTW in a new repo those repos could be one per odoo version, e.g.

docker-custom-odoo-11

With tags like this:

quay.io/opusvl/custom-odoo-11:2.1

@Nick-OpusVL
Copy link
Contributor Author

@PaulGWebster @PeterAlabaster @kkoci @acela82 @james-opusvl

Does anyone want to veto the plan to:

Get your vetos in by close of play on Friday please. I might be able to get things rolling faster if, assuming you have no questions, the people listed above unanimously upvote this comment before then (click the "plus smiley face" at the top of the comment then the Thumbs Up).

@Nick-OpusVL
Copy link
Contributor Author

https://github.com/OpusVL/docker-custom-odoo-11/ for Odoo 11 series created.

Before merging in #17 we must have completed milestone https://github.com/OpusVL/docker-custom-odoo-11/milestone/1 of the new repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants