Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(erc20): remove macro export from burnable #74

Closed
wants to merge 1 commit into from

add burnable to examples since function macro export was invalid

ad0c859
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

fix(erc20): remove macro export from burnable #74

add burnable to examples since function macro export was invalid
ad0c859
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded May 17, 2024 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (12)

contracts/src/erc20/mod.rs|3 col 30| warning: item in documentation is missing backticks
--> contracts/src/erc20/mod.rs:3:30
|
3 | //! We have followed general OpenZeppelin Contracts guidelines: functions
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
--> contracts/src/lib.rs:3:22
|
3 | #![warn(clippy::all, clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: #[warn(clippy::doc_markdown)] implied by #[warn(clippy::pedantic)]
help: try
|
3 | //! We have followed general OpenZeppelin Contracts guidelines: functions
| ~~~~~~~~~~~~~~
contracts/src/erc721/mod.rs|305 col 15| warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/erc721/mod.rs:305:15
|
305 | data: Bytes,
| ^^^^^ help: consider taking a reference instead: &Bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
= note: #[warn(clippy::needless_pass_by_value)] implied by #[warn(clippy::pedantic)]
contracts/src/erc721/mod.rs|471 col 5| warning: this method could have a #[must_use] attribute
--> contracts/src/erc721/mod.rs:471:5
|
471 | / pub fn is_approved_for_all(
472 | | &self,
473 | | owner: Address,
474 | | operator: Address,
475 | | ) -> bool {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
= note: #[warn(clippy::must_use_candidate)] implied by #[warn(clippy::pedantic)]
help: add the attribute
|
471 ~ #[must_use] pub fn is_approved_for_all(
472 + &self,
473 + owner: Address,
474 + operator: Address,
475 ~ ) -> bool {
|
contracts/src/erc721/mod.rs|495 col 5| warning: this method could have a #[must_use] attribute
--> contracts/src/erc721/mod.rs:495:5
|
495 | pub fn owner_of_inner(&self, token_id: U256) -> Address {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: #[must_use] pub fn _owner_of_inner(&self, token_id: U256) -> Address
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
contracts/src/erc721/mod.rs|506 col 5| warning: this method could have a #[must_use] attribute
--> contracts/src/erc721/mod.rs:506:5
|
506 | pub fn get_approved_inner(&self, token_id: U256) -> Address {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: #[must_use] pub fn _get_approved_inner(&self, token_id: U256) -> Address
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
contracts/src/erc721/mod.rs|522 col 5| warning: this method could have a #[must_use] attribute
--> contracts/src/erc721/mod.rs:522:5
|
522 | / pub fn is_authorized(
523 | | &self,
524 | | owner: Address,
525 | | spender: Address,
526 | | token_id: U256,
527 | | ) -> bool {
| |
^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
help: add the attribute
|
522 ~ #[must_use] pub fn is_authorized(
523 + &self,
524 + owner: Address,
525 + spender: Address,
526 + token_id: U256,
527 ~ ) -> bool {
|
contracts/src/erc721/mod.rs|735 col 15| warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/erc721/mod.rs:735:15
|
735 | data: Bytes,
| ^^^^^ help: consider taking a reference instead: &Bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
contracts/src/erc721/mod.rs|881 col 15| warning: this argument is passed by value, but not consumed in the function body
--> contracts/src/erc721/mod.rs:881:15
|
881 | data: Bytes,
| ^^^^^ help: consider taking a reference instead: &Bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value
contracts/src/erc721/mod.rs|129 col 1| warning: missing documentation for a struct
--> contracts/src/erc721/mod.rs:129:1
|
129 | / sol_interface! {
130 | | /// ERC-721 token receiver interface.
131 | | ///
132 | | /// Interface for any contract that wants to support safeTransfers
133 | | /// from ERC-721 asset contracts.
134 | | interface IERC721Receiver {
| |_____________________________^
|
note: the lint level is defined here
--> contracts/src/lib.rs:2:9
|
2 | #![warn(missing_docs, unreachable_pub, rust_2021_compatibility)]
| ^^^^^^^^^^^^
= note: this warning originates in the macro sol_interface (in Nightly builds, run with -Z macro-backtrace for more info)
contracts/src/erc721/mod.rs|129 col 1| warning: missing documentation for a struct field
--> contracts/src/erc721/mod.rs:129:1
|
129 | / sol_interface! {
130 | | /// ERC-721 token receiver interface.
131 | | ///
132 | | /// Interface for any contract that wants to support safeTransfers
... |
149 | | }
150 | | }
| |
^
|
= note: this warning originates in the macro sol_interface (in Nightly builds, run with -Z macro-backtrace for more info)
contracts/src/erc721/mod.rs|129 col 1| warning: missing documentation for an associated function
--> contracts/src/erc721/mod.rs:129:1
|
129 | / sol_interface! {
130 | | /// ERC-721 token receiver interface.
131 | | ///
132 | | /// Interface for any contract that wants to support safeTransfers
... |
149 | | }
150 | | }
| |
^
|
= note: this warning originates in the macro sol_interface (in Nightly builds, run with -Z macro-backtrace for more info)
contracts/src/erc721/mod.rs|129 col 1| warning: missing documentation for a method
--> contracts/src/erc721/mod.rs:129:1
|
129 | / sol_interface! {
130 | | /// ERC-721 token receiver interface.
131 | | ///
132 | | /// Interface for any contract that wants to support safeTransfers
... |
149 | | }
150 | | }
| |
^
|
= note: this warning originates in the macro sol_interface (in Nightly builds, run with -Z macro-backtrace for more info)