-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(erc20): remove macro export from burnable #74
Conversation
👷 Deploy request for contracts-stylus pending review.A Netlify team Owner will need to approve the deploy before you can run your build. Are you a team Owner? Visit the deploys page to approve it → Need more help? Learn more in the Netlify docs →
|
d6afe3f
to
ad0c859
Compare
The author of this PR, qalisander, is not an activated member of this organization on Codecov. |
I think better not to advertise this approach in public since it pretends that methods will be exported. |
Ah, I think @bidzyyys also implemented this change in #71 @qalisander |
That is right, it is refactored & removed in #71 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we should close the PR as it duplicates #71
Pardon, just noticed. Thought pausable pr will be just for pausable:) But you @bidzyyys can consider this approach create separate example for a burnable erc20 extension (if u think it makes sense ofk) |
I needed to refactor |
Resolves #73
PR Checklist