feat: Turn All Call::new_in into Call::new (i.e. Stop Supporting Reentrancy)

contracts/src/finance/vesting_wallet.rs

@@ -346,7 +346,7 @@
     ) -> Result<U256, Self::Error>;
 }
 
 #[public]
 impl IVestingWallet for VestingWallet {
     type Error = Error;
 
@@ -420,7 +420,7 @@
 
         let owner = self.ownable.owner();
 
-        call(Call::new_in(self).value(amount), owner, &[])?;
+        call(Call::new().value(amount), owner, &[])?;
 
         evm::log(EtherReleased { amount });
 

contracts/src/token/erc1155/mod.rs

@@ -384,7 +384,7 @@
     ) -> Result<(), Self::Error>;
 }
 
 #[public]
 impl IErc1155 for Erc1155 {
     type Error = Error;
 
@@ -786,7 +786,7 @@
     /// interface id or returned with error, then the error
     /// [`Error::InvalidReceiver`] is returned.
     fn _check_on_erc1155_received(
-        &mut self,
+        &self,
         operator: Address,
         from: Address,
         to: Address,
@@ -798,7 +798,7 @@
         }
 
         let receiver = IERC1155Receiver::new(to);
-        let call = Call::new_in(self);
+        let call = Call::new();
         let result = match details.transfer {
             Transfer::Single { id, value } => receiver
                 .on_erc_1155_received(call, operator, from, id, value, data),

contracts/src/token/erc20/extensions/permit.rs

@@ -84,7 +84,7 @@
 /// BorrowMut<Self>)`. Should be fixed in the future by the Stylus team.
 unsafe impl<T: IEip712 + StorageType> TopLevelStorage for Erc20Permit<T> {}
 
 #[public]
 impl<T: IEip712 + StorageType> Erc20Permit<T> {
     /// Returns the current nonce for `owner`.
     ///
@@ -174,7 +174,7 @@
 
         let hash: B256 = self.eip712.hash_typed_data_v4(struct_hash);
 
-        let signer: Address = ecdsa::recover(self, hash, v, r, s)?;
+        let signer: Address = ecdsa::recover(hash, v, r, s)?;
 
         if signer != owner {
             return Err(ERC2612InvalidSigner { signer, owner }.into());

contracts/src/token/erc721/mod.rs

@@ -1108,7 +1108,7 @@ impl Erc721 {
     /// interface id or returned with error, then the error
     /// [`Error::InvalidReceiver`] is returned.
     pub fn _check_on_erc721_received(
-        &mut self,
+        &self,
         operator: Address,
         from: Address,
         to: Address,
@@ -1122,7 +1122,7 @@ impl Erc721 {
         }
 
         let receiver = IERC721Receiver::new(to);
-        let call = Call::new_in(self);
+        let call = Call::new();
         let result = receiver.on_erc_721_received(
             call,
             operator,

contracts/src/utils/cryptography/ecdsa.rs

@@ -8,7 +8,6 @@
 use alloy_sol_types::{sol, SolType};
 use stylus_sdk::{
     call::{self, Call, MethodError},
-    storage::TopLevelStorage,
     stylus_proc::SolidityError,
 };
 
@@ -84,19 +83,18 @@
 /// * If the recovered address is `Address::ZERO`, then the error
 ///   [`Error::InvalidSignature`] is returned.
 ///
 /// # Panics
 ///
 /// * If the `ecrecover` precompile fails to execute.
 pub fn recover(
-    storage: &mut impl TopLevelStorage,
     hash: B256,
     v: u8,
     r: B256,
     s: B256,
 ) -> Result<Address, Error> {
     check_if_malleable(&s)?;
     // If the signature is valid (and not malleable), return the signer address.
-    _recover(storage, hash, v, r, s)
+    _recover(hash, v, r, s)
 }
 
 /// Calls `ecrecover` EVM precompile.
@@ -119,11 +117,10 @@
 /// * If the recovered address is `Address::ZERO`, then the error
 ///   [`Error::InvalidSignature`] is returned.
 ///
 /// # Panics
 ///
 /// * If the `ecrecover` precompile fails to execute.
 fn _recover(
-    storage: &mut impl TopLevelStorage,
     hash: B256,
     v: u8,
     r: B256,
@@ -136,11 +133,11 @@
         // but following the Solidity tests
         // https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/test/utils/cryptography/ECDSA.test.js
         // it should return `ECDSAInvalidSignature` error.
         return Err(ECDSAInvalidSignature {}.into());
     }
 
     let recovered =
-        call::static_call(Call::new_in(storage), ECRECOVER_ADDR, &calldata)
+        call::static_call(Call::new(), ECRECOVER_ADDR, &calldata)
             .expect("should call `ecrecover` precompile");
 
     let recovered = Address::from_slice(&recovered[12..]);

examples/ecdsa/src/lib.rs

@@ -21,7 +21,7 @@ impl ECDSAExample {
         r: B256,
         s: B256,
     ) -> Result<Address, Vec<u8>> {
-        let signer = ecdsa::recover(self, hash, v, r, s)?;
+        let signer = ecdsa::recover(hash, v, r, s)?;
         Ok(signer)
     }
 }