Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Turn All Call::new_in into Call::new (i.e. Stop Supporting Reentrancy) #440

Merged
merged 14 commits into from
Dec 12, 2024
Merged

feat: Turn All Call::new_in into Call::new (i.e. Stop Supporting Reentrancy) #440

merged 14 commits into from
Dec 12, 2024

Conversation

SarveshLimaye
Copy link
Contributor

Resolves #434

Replaced all Call::new_in into Call::new

PR Checklist

  • Tests
  • Documentation

@netlify Netlify
Copy link

netlify bot commented Dec 9, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus ready!

Name Link
🔨 Latest commit 9d9ecfd
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/675ac54ab302e800088a0ded
😎 Deploy Preview https://deploy-preview-440--contracts-stylus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

0xNeshi
0xNeshi reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean! 🚀
A couple more things and we're good to go

contracts/src/utils/cryptography/ecdsa.rs Show resolved Hide resolved
contracts/src/utils/cryptography/ecdsa.rs Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.8%. Comparing base (2334b28) to head (9d9ecfd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
contracts/src/utils/cryptography/ecdsa.rs 0.0% 5 Missing ⚠️
contracts/src/finance/vesting_wallet.rs 0.0% 1 Missing ⚠️
contracts/src/token/erc1155/mod.rs 50.0% 1 Missing ⚠️
contracts/src/token/erc20/extensions/permit.rs 0.0% 1 Missing ⚠️
contracts/src/token/erc721/mod.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/src/token/erc1155/extensions/supply.rs 81.1% <100.0%> (ø)
...tracts/src/token/erc1155/extensions/uri_storage.rs 98.2% <ø> (ø)
contracts/src/token/erc20/utils/safe_erc20.rs 17.0% <ø> (ø)
...ntracts/src/token/erc721/extensions/consecutive.rs 98.1% <ø> (ø)
contracts/src/finance/vesting_wallet.rs 55.6% <0.0%> (ø)
contracts/src/token/erc1155/mod.rs 96.9% <50.0%> (-0.1%) ⬇️
contracts/src/token/erc20/extensions/permit.rs 0.0% <0.0%> (ø)
contracts/src/token/erc721/mod.rs 97.2% <50.0%> (ø)
contracts/src/utils/cryptography/ecdsa.rs 57.8% <0.0%> (+10.7%) ⬆️

0xNeshi
0xNeshi reviewed Dec 10, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
0xNeshi
0xNeshi reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, almost there!

contracts/src/token/erc1155/mod.rs Outdated Show resolved Hide resolved
bidzyyys
bidzyyys reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @SarveshLimaye!

CHANGELOG.md Outdated Show resolved Hide resolved
@0xNeshi 0xNeshi changed the title feat:replace call::new_in to call::new feat: Turn All Call::new_in into Call::new (i.e. Stop Supporting Reentrancy) Dec 10, 2024
bidzyyys
bidzyyys reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

0xNeshi
0xNeshi approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

contracts/src/token/erc1155/mod.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
bidzyyys
bidzyyys reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply clippy warning, update CHANGELOG properly and we are good to go 🚀

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
0xNeshi
0xNeshi approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job @SarveshLimaye !

Don't worry about the failing "Check Links" job, it'll be handled

@qalisander
Merge remote-tracking branch 'origin/main' into feat/stop-reentrancy
a6f0f3f 
# Conflicts:
#	contracts/src/finance/vesting_wallet.rs
#	contracts/src/token/erc1155/mod.rs
#	contracts/src/token/erc20/extensions/permit.rs
#	contracts/src/token/erc20/utils/safe_erc20.rs
#	contracts/src/token/erc721/extensions/consecutive.rs
@bidzyyys bidzyyys requested a review from 0xNeshi December 12, 2024 11:23
bidzyyys
bidzyyys approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bidzyyys bidzyyys merged commit da0249b into OpenZeppelin:main Dec 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qalisander qalisander qalisander approved these changes

@bidzyyys bidzyyys bidzyyys approved these changes

@0xNeshi 0xNeshi 0xNeshi approved these changes

Assignees

@SarveshLimaye SarveshLimaye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Turn All Call::new_in into Call::new (i.e. Stop Supporting Reentrancy)
4 participants
@SarveshLimaye @0xNeshi @bidzyyys @qalisander