Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: poseidon hash #388
feat: poseidon hash #388
Changes from 138 commits
f7b5940
0b0cf3d
f305557
3369577
e41a63e
57d880c
76250c4
e897579
423503e
2563a53
264afa5
bd7e14c
5557280
c10c78a
1c76850
f62c298
a29a630
e8b722a
d80db6e
b8b7286
f6ddc87
2d84081
e53769e
2500b1a
375d042
fc77caf
d461172
745edcf
2de8819
b489a8e
ed3835b
cfc6d91
181339c
617f141
b0b1b1d
343064a
e77c5d0
b5b4a3a
74b86f7
886b955
1662190
090024b
c19dbf7
f86e6cc
8d43485
ffad719
b64460e
7275e0e
bb1eac4
d71142d
5ace24d
d08b77c
bdc066c
cd180c0
5dc350a
de78208
f5e64af
cb47ec0
c8f51ee
91d5b80
0771112
d822dce
1d47d65
5a85494
4a85e8e
7110fec
13d1ee7
4826fb5
702052c
0fa044f
474711c
3d6f402
c082f78
5ddd2bc
fbbf8f0
40f08a5
3361106
5c3961c
444754a
9f39a09
80ce59a
5c5251a
ddce394
a3b89ad
ed1ce9a
43b0483
fb0932f
dea904f
9c9e8fa
b80fb7a
bdce479
1b543c4
66c85cd
6cc65fc
e98a830
c964fb2
2998534
de698b0
387527e
f0c8e94
30430e6
24c1e6e
7e213d2
1df589e
79caad0
14d7546
2043e83
6fa8405
f8886b8
bdc94ad
3e7b37a
f02c161
9f580cc
1147c88
99cf440
080c60f
088b5c1
639c720
f5d870a
c48488d
850023d
9e8cdb5
2540dbb
745e3e4
dfeb6cc
231e739
a000bc5
b866627
33d13e1
0593bc4
f73cbae
c762be8
fcb1db5
72b01ec
8b2da4b
0213da1
5a4b537
93728e5
3444407
b29f99c
e31cd8c
a125af0
4c8f3e8
7f31aed
4d7070e
215ddf4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again curios, why are these not marked as other tests with:
#[cfg(all(test, feature = "std"))]
though
merkle
andhash
have it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also curious how "std" feature flag actual to all our lib.. Since it usually runs altogether with test cases..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bidzyyys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried updating all lib/crypto-related tests to have the
#[cfg(all(test, feature = "std"))]
annotation, and it completely solved all the compilation issues, many of which you addressed in this PR (see previous comments).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curios, why was
Uint::from_be_hex
not appropriate to use here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uint::from_be_hex
requires specific length of hex string. Like 2 byte "1234" number wont be converted to U64 with leading zeros. Only 8 byte hex number does so. Of course we could format all our const values to proper length, but I've just decided to add our const hex conversion and copy constants from referenced implementation here in whitepaper