Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: poseidon hash #388

Merged
merged 146 commits into from
Dec 10, 2024
Merged

feat: poseidon hash #388

merged 146 commits into from
Dec 10, 2024

Conversation

qalisander
Copy link
Member

@qalisander qalisander commented Oct 31, 2024 •
edited
Loading

Resolves #264

PR Checklist

  • Tests
  • Documentation

@qalisander
Copy link
Member Author

qalisander commented Nov 28, 2024 •
edited
Loading

looks wizard-y

I see I should add a bit more clarifying comments

@bidzyyys bidzyyys requested a review from ggonzalez94 December 4, 2024 11:59
bidzyyys
bidzyyys reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @qalisander, passed first iteration.

lib/crypto/src/poseidon2/mod.rs Show resolved Hide resolved
lib/crypto/src/poseidon2/mod.rs Outdated Show resolved Hide resolved
lib/crypto/src/poseidon2/mod.rs Show resolved Hide resolved
lib/crypto/src/poseidon2/mod.rs Show resolved Hide resolved
lib/crypto/src/poseidon2/mod.rs Outdated Show resolved Hide resolved
lib/crypto/src/poseidon2/instance/mod.rs Outdated Show resolved Hide resolved
lib/crypto/src/poseidon2/instance/pallas.rs Outdated Show resolved Hide resolved
@bidzyyys
Copy link
Collaborator

bidzyyys commented Dec 4, 2024

@qalisander update CHANGELOG please

0xNeshi
0xNeshi approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@0xNeshi 0xNeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

lib/crypto/src/bigint.rs Outdated Show resolved Hide resolved
@bidzyyys bidzyyys self-requested a review December 10, 2024 09:36
@0xNeshi 0xNeshi self-requested a review December 10, 2024 10:23
bidzyyys
bidzyyys reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @qalisander, left small comments.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
bidzyyys
bidzyyys approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bidzyyys bidzyyys merged commit 091d06d into main Dec 10, 2024
24 checks passed
@bidzyyys bidzyyys deleted the poseidon branch December 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidzyyys bidzyyys bidzyyys approved these changes

@0xNeshi 0xNeshi 0xNeshi approved these changes

@ggonzalez94 ggonzalez94 Awaiting requested review from ggonzalez94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Poseidon Hash
3 participants
@qalisander @bidzyyys @0xNeshi