Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

power(bpu): optimize CGE of bpu/predictors_io_update #3579

Merged
merged 5 commits into from
Nov 19, 2024
Merged

power(bpu): optimize CGE of bpu/predictors_io_update #3579

merged 5 commits into from
Nov 19, 2024

Conversation

Lawrence-ID
Copy link
Collaborator

Bpu: Optimize CGE of bpu/predictors_io_update by moving update regs into predictors, except for the update PC

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 0320241

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
0320241 1.865 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
0c658d9 0.450 2.695 1.186 2.400 0.919 1.397 2.747 3.212
0345934 0.450 2.695 1.186 2.400 0.919 1.397 1.454 3.415 2.747 3.212
63d67ef 1.865 2.695 1.186 2.832 2.488 0.919 1.397 1.454 3.415 2.423 3.212
e9f7c49 1.865 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212
7acf8b7 1.855 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212
78a6e80 1.855 0.450 2.695 1.186 2.832 2.488 2.400 0.919 1.397 1.454 3.415 2.747 2.423 3.212
ecdd929 1.855 0.450 2.695 1.186 2.822 2.490 2.400 0.919 1.397 1.454 3.362 2.756 2.418 3.212
cdb8dc6 1.865 0.450 2.695 1.186 2.822 2.490 2.400 0.919 1.397 1.454 3.362 2.756 2.418 3.212

Lingrui98
Lingrui98 reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Lingrui98 Lingrui98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pc field of update bundle and other update data are not in the same stage, would be better if add some comments to mark that information

@Lawrence-ID Lawrence-ID added the do not merge Do not merge this pull request label Sep 19, 2024
@Lawrence-ID
chore: add some comments
c0bf3f4 
pc field of update bundle and other update data are not in the same stage
@Lawrence-ID Lawrence-ID added power about power design or optimization and removed do not merge Do not merge this pull request labels Oct 28, 2024
eastonman
eastonman requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@eastonman eastonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should be rebased to master branch.

@eastonman eastonman mentioned this pull request Oct 28, 2024
Closed
eastonman
eastonman approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@eastonman eastonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: c37c389

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
c37c389 1.917 0.450 2.696 1.228 2.840 2.464 2.398 0.920 1.430 2.069 3.432 2.720 2.387 3.261

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
3e2285d 1.917 0.450 2.701 1.226 2.840 2.464 2.398 0.921 1.430 2.069 3.437 2.716 2.387 3.261
c49ebec 1.917 0.450 2.696 1.230 2.840 2.464 2.398 0.920 1.430 2.069 3.432 2.720 2.387 3.261
cfa1639 0.450 2.701 1.244 2.473 2.398 0.915 1.429 1.700 3.470 2.729 3.280
0d13456 1.920 0.450 2.701 1.234 2.891 2.473 2.398 0.915 1.429 1.700 3.470 2.729 2.417 3.280
011f1ef 1.917 0.450 2.701 1.241 2.891 2.473 2.398 0.915 1.429 1.700 3.470 2.729 2.417 3.280

@Lawrence-ID Lawrence-ID changed the title Bpu: Optimize CGE of bpu/predictors_io_update power(bpu): Optimize CGE of bpu/predictors_io_update Nov 19, 2024
@Lawrence-ID Lawrence-ID changed the title power(bpu): Optimize CGE of bpu/predictors_io_update power(bpu): optimize CGE of bpu/predictors_io_update Nov 19, 2024
@Gao-Zeyu Gao-Zeyu merged commit 03426fe into OpenXiangShan:master Nov 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lingrui98 Lingrui98 Lingrui98 left review comments

@eastonman eastonman eastonman approved these changes

Assignees
No one assigned
Labels
power about power design or optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lawrence-ID @XiangShanRobot @eastonman @Lingrui98 @Gao-Zeyu