Implement error handling in JS #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
commented
Apr 10, 2024
Comment on lines
-1
to
-5
| {% set translations = { | ||
| 'authentication.start_button': 'authentication.start_button' | trans, | ||
| 'registration.start_button': 'registration.start_button' | trans, | ||
| 'registration.sub_title': 'registration.sub_title' | trans, | ||
| 'status.registration_initial': 'status.registration_initial' | trans, |
There was a problem hiding this comment.
The no longer used translations (for the old react app) have been removed from the template.
parijke
approved these changes
Apr 10, 2024
MKodde
force-pushed
the
feature/rejuvenation
branch
from
5353d1b to
23ff0d1
Compare
MKodde
force-pushed
the
feature/rejuvination-error-reports
branch
from
295a56d to
b6124f0
Compare
|
Thanks for the feedback and your review effort 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old style of error handling is simulated in this PR
The react app would render an error page whenever an unrecoverable error occurred. The new StimulusJS/SymfonyUX setup was a bit different in this regard. It would just ignore these JS errors and show them in the console. For example, leaving the user 'stranded' when the cancel button was pressed on the webauthn dialog in the browser.
A simplistic approach was chosen to catch the uncaught JS errors. An error listener was registered in the new error_handling.js file. This then displays the pre-rendered error page and fills in the blanks with the error details that are already available as JS variables in the window object.
Only the timestamp and the error message itself are parsed in the error handling routine. Any missing fields are stripped from the error report table.
Finally the retry button was added back.