Upgrade the app to use Symfony 6 and PHP 8.2 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
feature/rejuvenation
branch
3 times, most recently
from
6d75a5a to
26e71d1
Compare
MKodde
force-pushed
the
feature/rejuvenation
branch
from
84e41dc to
32a7ac8
Compare
Kind off.. Most accute issues have been addressed. Some details remain to be fixed (in next commits)
Use the OpenConext devconf stepup environment instead
- They should use the PHP82 base images. - The prod container no longer overwrites the monolog config. This is now set by default - The parameters.yaml overwrite action was modified to use the new config location
And cleaned up some mess while at it
The rule of diminishing returns applied here. Much effort should be put into making the app and the infra it uses type safe on a higher level. That was not worth it at this point.
- The logger now wraps the context of the log message in {} curly
brackets, updated the snapshots accordingly.
- Some of the classes we used to mock are now marked as final in the
webauthn library. I now use a real instance of these options classes
to work around that. Seems to work just fine.
The SF bridge variant can not be autowired
The database url and the app secret are no longer configurable via the env-vars. But need to be configured in the parameters.yaml file.
We get these insights from other tools like scrutenizer.
parijke
reviewed
Apr 11, 2024
MKodde
force-pushed
the
feature/rejuvenation
branch
from
45169ea to
68cbac6
Compare
Renamed from fido2-mds.cer to root.crt
- Add version info the environment of the container - Upgrade github actions
By merging the test and dev config to be the default config. And only provide a prod override
The MicroKernelTrait provides 90% of all logic for the kernel We only need the getProjectDir implementation.
Some namespace changes needed an update of the existing baseline
MKodde
force-pushed
the
feature/rejuvenation
branch
2 times, most recently
from
5729209 to
13f1cf8
Compare
1. The attestation conveyance is reset to NONE, it was previously enabled to allow for vendor certificate based attestation.
MKodde
force-pushed
the
feature/rejuvenation
branch
from
13f1cf8 to
50ec2c2
Compare
parijke
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrading of the WebAuthn component to SF 6.4
For details se the extensive commit log of this PR
Edit 10-4-2024
The TS/React app was fully replaced with the Spomky Webauthn frontend. This consists of a StimulusJS based application that deals with the browser webauthn interactions.
The final work on this integration was done in #118. Here the error handling was re-introduced.
Original message
At this point the Symfony app is not correctly working together with the TS app. The PSR7 http messages are not compatible with one another. For now I parked the resolving of that issue untill we start overhauling the application functionally. @KarsanHAM is working on preparing for that task as we speak.