Show the user friendly error page on authn failure #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
bugfix/show-correct-authz-error-page
branch
from
8a84072 to
66d2a36
Compare
MKodde
commented
Sep 19, 2024
Comment on lines
+52
to
+56
| Surfnet\SamlBundle\Security\Authentication\Handler\FailureHandler: | ||
| class: Surfnet\StepupRa\RaBundle\Security\Authentication\Handler\FailureHandler | ||
| public: false | ||
| arguments: | ||
| $exceptionController: '@Surfnet\StepupRa\RaBundle\Controller\ExceptionController' |
There was a problem hiding this comment.
I'm overriding the default FailureHandler here, allowing custom authentication failure handling.
In our case, we show our own stepup user facing error page. Showing a table with error parameters that can be sent to the support team. Helping them enormously in debugging/audit trailing the failure.
| ); | ||
| $this->logger->notice($message); | ||
| // The exception controller is used to show the failed authentication | ||
| return $this->exceptionController->show($request, $exception); |
There was a problem hiding this comment.
Might be strange to inject a controller, and render a response here. But this does exactly what we want this error handler to do. 🤷♂️
johanib
reviewed
Sep 19, 2024
src/Surfnet/StepupRa/RaBundle/Security/Authentication/Handler/FailureHandler.php
Outdated
Show resolved
Hide resolved
MKodde
force-pushed
the
bugfix/show-correct-authz-error-page
branch
from
66d2a36 to
7498ed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://www.pivotaltracker.com/story/show/188230772
See for test coverage: OpenConext/OpenConext-devconf#16