RA - Error on invalid token

[phavekes]

This issue is imported from pivotal - Originaly created at Sep 6, 2024 by Peter Havekes

When the user has no token with a sufficient level to enter the RA portal, the error
"Error - Not authorised to sign in
You are not authorised to sign in"
was shown. After the php8 update the error displayed is :
Authentication failure: An authentication exception occurred.: "Failed SAMLResponse parsing"

[phavekes]

Foutmelding voor upgrade (Peter Havekes - Sep 6, 2024)

[phavekes]

Foutmelding na uiograde
(Peter Havekes - Sep 6, 2024)

[phavekes]

I scoped this out. The SAML bundle Authentication FailureHandler (vendor/surfnet/stepup-saml-bundle/src/Security/Authentication/Handler/FailureHandler.php) is responsible for this new behavior.

It now returns a Http Response object containing te html described in the bug report.

What might help in fixing this issue is to create a custom FailureHandler that reproduces the previous behavior. And that returns a (Redirect)Response to the regular error route. (Michiel Kodde - Sep 11, 2024)

[phavekes]

@phavekes 

I'm having trouble reproducing this.
What I did:
I changed \Surfnet\SamlBundle\Security\Authentication\Handler\ProcessSamlAuthenticationHandler to always throw throw new AuthenticationException(\'Failed SAMLResponse parsing\', 0, new \RuntimeException(\'Erreur\'));
But it always shows this screen:

I also tried running my local checkout in prod mode, but the result is the same.

But, now I see, based on the timestamps, that @michielkodde has probably already fixed this: 319e682

I even reviewed it #332 🙈 (Johan Kromhout - Oct 31, 2024)

[phavekes]

This was already solved in 319e682
(Peter Havekes - Oct 31, 2024)