Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event data integrity test #137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions tests/behat/features/event_verification.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
Feature: The application managers are concerned with correct data ending up in the event stream
In order to ensure no sensitive data ends up in the event stream
As an administrator
I must check the payload of the events for presence of sensitive data

Scenario: Provision an institution and a user to promote later on by an authorized institution
Given institution "institution-a.example.com" can "use_ra" from institution "institution-a.example.com"
And institution "institution-a.example.com" can "select_raa" from institution "institution-a.example.com"
And institution "institution-d.example.com" can "use_ra" from institution "institution-a.example.com"
And a user "Jane Toppan" identified by "urn:collab:person:institution-a.example.com:jane-a-ra" from institution "institution-a.example.com"
And the user "urn:collab:person:institution-a.example.com:jane-a-ra" has a vetted "yubikey"
And the user "urn:collab:person:institution-a.example.com:jane-a-ra" has the role "ra" for institution "institution-a.example.com"

Scenario: RA user can vet a token from an institution it is RA for
Given I am logged in into the selfservice portal as "joe-a1"
And I register a new SMS token
And I verify my e-mail address
When I am logged in into the ra portal as "jane-a-ra" with a "yubikey" token
And I vet the last added second factor
Then the resulting "SecondFactorVetted" event should not contain "common_name"
And the resulting "SecondFactorVetted" event should not contain "vetting_type"
And the resulting "SecondFactorVetted" event should not contain "document_number"
And the resulting "SecondFactorVetted" event should contain "name_id"
35 changes: 35 additions & 0 deletions tests/behat/features/src/Repository/EventStreamRepository.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?php

namespace Surfnet\StepupBehat\Repository;

use PDO;

/**
* A poor mans repository, a pdo connection to the test database is established in the constructor
*/
class EventStreamRepository
{
/**
* @var PDO
*/
private $connection;

public function __construct()
{
// Settings
$dbUser = 'root';
$dbPassword = 'password';
$dbName = 'middleware_test';
$dsn = 'mysql:host=127.0.0.1;dbname=%s';
// Open a PDO connection
$this->connection = new PDO(sprintf($dsn, $dbName), $dbUser, $dbPassword);
}

public function findLatestByEventName(string $name): array
{
$sql = 'SELECT * FROM `event_stream` WHERE type LIKE CONCAT("%", :name) ORDER BY recorded_on DESC LIMIT 1';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you only check the latest event? If we check the complete event_stream, we could prevent other mistakes.

$statement = $this->connection->exec($sql);
$statement->execute(['name' => $name]);
return $statement->fetch();
}
}