Add event data integrity test #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Middleware command handler tests the correct data on an Event, this however is the deserialized data that is constructed on the event. The event payload may contain additional data which in turn could be sensitive data. This behat test is created to test the presence of certain data on the event.
MKodde
force-pushed
the
feature/test-event-data
branch
from
cec2f57 to
04c0edb
Compare
phavekes
approved these changes
Jun 4, 2021
|
|
||
| public function findLatestByEventName(string $name): array | ||
| { | ||
| $sql = 'SELECT * FROM `event_stream` WHERE type LIKE CONCAT("%", :name) ORDER BY recorded_on DESC LIMIT 1'; |
There was a problem hiding this comment.
Why do you only check the latest event? If we check the complete event_stream, we could prevent other mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Middleware command handler tests the correct data on an Event, this however is the deserialized data that is constructed on the event. The event payload may contain additional data which in turn could be sensitive data.
This behat test is created to test the presence of certain data on the event.