This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Remove unnecessary replay binary memory size check in JIT validator #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlasmaPower
changed the title
Codecov Report
@@ Coverage Diff @@
## stylus #171 +/- ##
==========================================
- Coverage 56.45% 56.31% -0.15%
==========================================
Files 276 276
Lines 42751 42748 -3
==========================================
- Hits 24137 24072 -65
- Misses 16164 16210 +46
- Partials 2450 2466 +16 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from nitro OffchainLabs/nitro#1928 to avoid merge conflicts
We don't check memory bounds anywhere else because we don't need to. Panicking on out-of-bounds memory access is perfectly fine here, because it'll just be returned as an error to the validation service via the socket closing (and the panic will be printed to stderr).