Remove unnecessary memory size check in JIT validator #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Codecov Report
@@ Coverage Diff @@
## master #1928 +/- ##
==========================================
- Coverage 28.98% 28.96% -0.03%
==========================================
Files 220 220
Lines 32962 32962
==========================================
- Hits 9554 9547 -7
- Misses 22345 22352 +7
Partials 1063 1063 |
tsahee
approved these changes
Oct 17, 2023
|
Good call. Moved to OffchainLabs/stylus#171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't check memory bounds anywhere else because we don't need to. Panicking on out-of-bounds memory access is perfectly fine here, because it'll just be returned as an error to the validation service via the socket closing (and the panic will be printed to stderr).