Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable system tests to work from VS Code Debugger. #2274

Merged
merged 4 commits into from
May 10, 2024
Merged

Conversation

eljobe
Copy link
Member

@eljobe eljobe commented May 6, 2024

Before this change, when launching some of the system tests from the VS Code debugger UI, the machine loader was unable to locate the jit binary because the system tests don't actually have "test" in path leading up to the test executable.

Before this change, when launching some of the system tests from the
VS Code debugger UI, the machine loader was unable to locate the jit
binary because the system tests don't actually have "test" in path
leading up to the test executable.
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 6, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe eljobe enabled auto-merge May 10, 2024 07:52
@eljobe eljobe merged commit 8b1b73f into master May 10, 2024
8 of 9 checks passed
@eljobe eljobe deleted the sys-test-debug branch May 10, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants