Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the nitro CI builds. #181

Closed
wants to merge 1 commit into from
Closed

Fix the nitro CI builds. #181

wants to merge 1 commit into from

Conversation

eljobe
Copy link
Member

@eljobe eljobe commented May 6, 2024

For some reason, the master branch of nitro won't build the contracts if there are any remappings specified for a yul build.

This change removes the remappings for the yul build.

For some reason, the master branch of nitro won't build the contracts
if there are any remappings specified for a yul build.

This change removes the remappings for the yul build.
@gzeoneth
Copy link
Member

gzeoneth commented May 6, 2024

sorry I didn't see this and already created #182
also want to merge into develop instead, but let me know if main without this hotfix is a blocker

@gzeoneth gzeoneth closed this May 6, 2024
@eljobe
Copy link
Member Author

eljobe commented May 6, 2024

sorry I didn't see this and already created #182 also want to merge into develop instead, but let me know if main without this hotfix is a blocker

I mean, we do need the fix in the contracts submodule in the nitro repository or our CI fails.
See: OffchainLabs/nitro#2274

@gzeoneth gzeoneth deleted the hotfix-ci branch August 9, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants