Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: yul remapping issue #636

Merged
merged 2 commits into from
May 6, 2024
Merged

fix: yul remapping issue #636

merged 2 commits into from
May 6, 2024

Conversation

gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented May 6, 2024

@gzeoneth gzeoneth requested a review from shotaronowhere May 6, 2024 14:13
@eljobe
Copy link
Member

eljobe commented May 6, 2024

FYI, I am working on a different workaround. Here: OffchainLabs/nitro-contracts#180

@eljobe
Copy link
Member

eljobe commented May 6, 2024

Sorry. Moved it to an appropriately named "hotfix-ci" branch. OffchainLabs/nitro-contracts#181

@gzeoneth
Copy link
Member Author

gzeoneth commented May 6, 2024

FYI, I am working on a different workaround. Here: OffchainLabs/nitro-contracts#180

that actually looks good, but I will keep the remapping hardcoded in the default profile
will put up another PR into develop on nitro-contracts

@eljobe
Copy link
Member

eljobe commented May 6, 2024

FYI, I am working on a different workaround. Here: OffchainLabs/nitro-contracts#180

that actually looks good, but I will keep the remapping hardcoded in the default profile will put up another PR into develop on nitro-contracts

Why don't I just do that as part of the current Pull Request (now moved to: OffchainLabs/nitro-contracts#181)

@gzeoneth gzeoneth force-pushed the hotfix-foundry-issue branch from 9a21a97 to 22d228b Compare May 6, 2024 14:26
@gzeoneth
Copy link
Member Author

gzeoneth commented May 6, 2024

FYI, I am working on a different workaround. Here: OffchainLabs/nitro-contracts#180

that actually looks good, but I will keep the remapping hardcoded in the default profile will put up another PR into develop on nitro-contracts

Why don't I just do that as part of the current Pull Request (now moved to: OffchainLabs/nitro-contracts#181)

sorry I didn't see this and already created OffchainLabs/nitro-contracts#182
also want to merge into develop instead, but let me know if main without this hotfix is a blocker

@gzeoneth gzeoneth changed the title workaround: foundry issue 7869 fix: yul remapping issue May 6, 2024
@gzeoneth gzeoneth added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 1b34c03 May 6, 2024
7 of 8 checks passed
@gzeoneth gzeoneth deleted the hotfix-foundry-issue branch May 6, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants