Tipping tx type #1510
Closed
Tipping tx type #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
- Coverage 52.96% 49.44% -3.53%
==========================================
Files 272 259 -13
Lines 35403 31360 -4043
Branches 555 555
==========================================
- Hits 18752 15505 -3247
+ Misses 14449 13649 -800
- Partials 2202 2206 +4 |
This reverts commit b5379c0.
| @@ -406,7 +406,10 @@ func (s *Sequencer) PublishTransaction(parentCtx context.Context, tx *types.Tran | |||
| } | |||
| } | |||
|
|
|||
| func (s *Sequencer) preTxFilter(_ *params.ChainConfig, header *types.Header, statedb *state.StateDB, _ *arbosState.ArbosState, tx *types.Transaction, sender common.Address) error { | |||
| func (s *Sequencer) preTxFilter(_ *params.ChainConfig, header *types.Header, statedb *state.StateDB, arbosState *arbosState.ArbosState, tx *types.Transaction, sender common.Address) error { | |||
| if tx.Type() == types.ArbitrumSubtypedTxType && arbosState.ArbOSVersion() < 11 { | |||
There was a problem hiding this comment.
Need to change this to ArbOSVersion 12
There was a problem hiding this comment.
I'll address this change in the new version of this PR: #1901
joshuacolvin0
requested changes
Sep 27, 2023
|
replaced by: #1901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ArbitrumSubtypedTx)DynamicFeeTxand supports collection the priority fee (ArbitrumTippingTx)needs: OffchainLabs/go-ethereum#204