Tipping tx type #204
Closed
Tipping tx type #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicxyyz
commented
Mar 14, 2023
| subtype := uint64(tx.TxSubtype()) | ||
| enc.Subtype = (*hexutil.Uint64)(&subtype) | ||
| switch subtype { | ||
| case ArbitrumTippingTxSubtype: |
There was a problem hiding this comment.
alternatively we could call here a method of ArbitrumSubtypedTx (something like tx.(*ArbitrumSubtypedTx).EncodeJSON(&enc) ) and have the specific tx subtypes implement the encoding. The similar thing could be done for RLP encoding.
This could be nice to have almost everything that's needed to implement new tx subtype in one place, but also it would take it out of context, so initially I followed geths file split.
|
replaced by: #260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: OffchainLabs/nitro#1510