Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Reproducible Builds #56

Merged
merged 41 commits into from
Jul 26, 2024

confs

18dc6e8
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Revamp Reproducible Builds #56

confs
18dc6e8
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jul 26, 2024 in 1s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.80.0 (051478957 2024-07-21)
  • cargo 1.80.0 (376290515 2024-07-16)
  • clippy 0.1.80 (0514789 2024-07-21)

Annotations

Check warning on line 253 in check/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `write!` args 

warning: `to_string` applied to a type that implements `Display` in `write!` args
   --> check/src/main.rs:253:28
    |
253 |             self.common_cfg.to_string(),
    |                            ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check warning on line 241 in check/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args 

warning: `to_string` applied to a type that implements `Display` in `format!` args
   --> check/src/main.rs:241:84
    |
241 |                 Some(path) => format!("--keystore-password-path={}", path.display().to_string()),
    |                                                                                    ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check warning on line 229 in check/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args 

warning: `to_string` applied to a type that implements `Display` in `format!` args
   --> check/src/main.rs:229:78
    |
229 |                 Some(path) => format!("--private-key-path={}", path.display().to_string()),
    |                                                                              ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check warning on line 214 in check/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `write!` args 

warning: `to_string` applied to a type that implements `Display` in `write!` args
   --> check/src/main.rs:214:22
    |
214 |             self.auth.to_string(),
    |                      ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check warning on line 213 in check/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `write!` args 

warning: `to_string` applied to a type that implements `Display` in `write!` args
   --> check/src/main.rs:213:30
    |
213 |             self.check_config.to_string(),
    |                              ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check warning on line 193 in check/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `format!` args 

warning: `to_string` applied to a type that implements `Display` in `format!` args
   --> check/src/main.rs:193:71
    |
193 |                 Some(path) => format!("--wasm-file={}", path.display().to_string()),
    |                                                                       ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args

Check warning on line 191 in check/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`to_string` applied to a type that implements `Display` in `write!` args 

warning: `to_string` applied to a type that implements `Display` in `write!` args
   --> check/src/main.rs:191:28
    |
191 |             self.common_cfg.to_string(),
    |                            ^^^^^^^^^^^^ help: remove this
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
    = note: `#[warn(clippy::to_string_in_format_args)]` on by default

Check warning on line 97 in check/src/verify.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
  --> check/src/verify.rs:97:37
   |
97 |             extract_compressed_wasm(&*result.input).len()
   |                                     ^^^^^^^^^^^^^^ help: try: `&result.input`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

Check warning on line 75 in check/src/verify.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref 

warning: deref which would be done by auto-deref
  --> check/src/verify.rs:75:65
   |
75 |         let tx_prelude = extract_program_evm_deployment_prelude(&*result.input);
   |                                                                 ^^^^^^^^^^^^^^ help: try: `&result.input`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
   = note: `#[warn(clippy::explicit_auto_deref)]` on by default

Check warning on line 44 in check/src/docker.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> check/src/docker.rs:44:38
   |
44 |     let name = version_to_image_name(&version);
   |                                      ^^^^^^^^ help: change this to: `version`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 59 in check/src/cache.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `Address` which implements the `Copy` trait 

warning: using `clone` on type `Address` which implements the `Copy` trait
  --> check/src/cache.rs:59:25
   |
59 |     let cache_manager = cache_manager_addrs.last().unwrap().clone();
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*cache_manager_addrs.last().unwrap()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
   = note: `#[warn(clippy::clone_on_copy)]` on by default
View more details on GitHub Actions