Revamp Reproducible Builds #246
rauljordancheck.yml
on: pull_request
stable / fmt
13s
Matrix: clippy
Annotations
15 warnings
|
stable / fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
stable / fmt
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
`to_string` applied to a type that implements `Display` in `write!` args:
check/src/main.rs#L253
warning: `to_string` applied to a type that implements `Display` in `write!` args
--> check/src/main.rs:253:28
|
253 | self.common_cfg.to_string(),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
|
|
`to_string` applied to a type that implements `Display` in `format!` args:
check/src/main.rs#L241
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> check/src/main.rs:241:84
|
241 | Some(path) => format!("--keystore-password-path={}", path.display().to_string()),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
|
|
`to_string` applied to a type that implements `Display` in `format!` args:
check/src/main.rs#L229
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> check/src/main.rs:229:78
|
229 | Some(path) => format!("--private-key-path={}", path.display().to_string()),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
|
|
`to_string` applied to a type that implements `Display` in `write!` args:
check/src/main.rs#L214
warning: `to_string` applied to a type that implements `Display` in `write!` args
--> check/src/main.rs:214:22
|
214 | self.auth.to_string(),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
|
|
`to_string` applied to a type that implements `Display` in `write!` args:
check/src/main.rs#L213
warning: `to_string` applied to a type that implements `Display` in `write!` args
--> check/src/main.rs:213:30
|
213 | self.check_config.to_string(),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
|
|
`to_string` applied to a type that implements `Display` in `format!` args:
check/src/main.rs#L193
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> check/src/main.rs:193:71
|
193 | Some(path) => format!("--wasm-file={}", path.display().to_string()),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
|
|
`to_string` applied to a type that implements `Display` in `write!` args:
check/src/main.rs#L191
warning: `to_string` applied to a type that implements `Display` in `write!` args
--> check/src/main.rs:191:28
|
191 | self.common_cfg.to_string(),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
|
deref which would be done by auto-deref:
check/src/verify.rs#L97
warning: deref which would be done by auto-deref
--> check/src/verify.rs:97:37
|
97 | extract_compressed_wasm(&*result.input).len()
| ^^^^^^^^^^^^^^ help: try: `&result.input`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
|
|
deref which would be done by auto-deref:
check/src/verify.rs#L75
warning: deref which would be done by auto-deref
--> check/src/verify.rs:75:65
|
75 | let tx_prelude = extract_program_evm_deployment_prelude(&*result.input);
| ^^^^^^^^^^^^^^ help: try: `&result.input`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
check/src/docker.rs#L44
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> check/src/docker.rs:44:38
|
44 | let name = version_to_image_name(&version);
| ^^^^^^^^ help: change this to: `version`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
using `clone` on type `Address` which implements the `Copy` trait:
check/src/cache.rs#L59
warning: using `clone` on type `Address` which implements the `Copy` trait
--> check/src/cache.rs:59:25
|
59 | let cache_manager = cache_manager_addrs.last().unwrap().clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*cache_manager_addrs.last().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
stable / clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
stable / clippy
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|