Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run console tests in serial #718

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Run console tests in serial #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion source/Octopus.Tentacle.Tests.Integration/TentacleCommandLineTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ public async Task CommandSpecificHelpAsJsonLooksSensibleToHumans(TentacleConfigu

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
[NonParallelizable]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait so the one that was run in serial could be run in parallel 😆

public async Task HelpForInstanceSpecificCommandsAlwaysWorks(TentacleConfigurationTestCase tc)
{
var (_, stdout, stderr) = await RunCommand(tc, "help", "--format=json");
Expand Down Expand Up @@ -327,6 +326,8 @@ public async Task HelpForInstanceSpecificCommandsAlwaysWorks(TentacleConfigurati

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
// Run these tests in serial to avoid conflicts
[NonParallelizable]
public async Task InvalidInstance(TentacleConfigurationTestCase tc)
{
var (exitCode, stdout, stderr) = await RunCommand(tc, "show-thumbprint", "--instance=invalidinstance");
Expand All @@ -339,6 +340,8 @@ public async Task InvalidInstance(TentacleConfigurationTestCase tc)

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
// Run these tests in serial to avoid conflicts
[NonParallelizable]
public async Task ShowThumbprintCommandText(TentacleConfigurationTestCase tc)
{
await using var clientAndTentacle = await tc.CreateBuilder().Build(CancellationToken);
Expand All @@ -351,6 +354,8 @@ public async Task ShowThumbprintCommandText(TentacleConfigurationTestCase tc)

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
// Run these tests in serial to avoid conflicts
[NonParallelizable]
public async Task ShowThumbprintCommandJson(TentacleConfigurationTestCase tc)
{
await using var clientAndTentacle = await tc.CreateBuilder().Build(CancellationToken);
Expand All @@ -363,6 +368,8 @@ public async Task ShowThumbprintCommandJson(TentacleConfigurationTestCase tc)

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
// Run these tests in serial to avoid conflicts
[NonParallelizable]
public async Task ListInstancesCommandText(TentacleConfigurationTestCase tc)
{
await using var clientAndTentacle = await tc.CreateBuilder().Build(CancellationToken);
Expand All @@ -376,6 +383,8 @@ public async Task ListInstancesCommandText(TentacleConfigurationTestCase tc)

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
// Run these tests in serial to avoid conflicts
[NonParallelizable]
public async Task ListInstancesCommandJson(TentacleConfigurationTestCase tc)
{
await using var clientAndTentacle = await tc.CreateBuilder().Build(CancellationToken);
Expand All @@ -390,6 +399,7 @@ public async Task ListInstancesCommandJson(TentacleConfigurationTestCase tc)

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
// Run these tests in serial to avoid conflicts
[NonParallelizable]
public async Task ShouldLogStartupDiagnosticsToInstanceLogFileOnly(TentacleConfigurationTestCase tc)
{
Expand Down Expand Up @@ -479,6 +489,7 @@ to text.

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
// Run these tests in serial to avoid conflicts
[NonParallelizable]
public async Task ShowConfigurationCommand(TentacleConfigurationTestCase tc)
{
Expand All @@ -495,6 +506,7 @@ public async Task ShowConfigurationCommand(TentacleConfigurationTestCase tc)

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
// Run these tests in serial to avoid conflicts
[NonParallelizable]
public async Task ShowConfigurationCommandOnPartiallyConfiguredTentacle(TentacleConfigurationTestCase tc)
{
Expand All @@ -511,6 +523,7 @@ public async Task ShowConfigurationCommandOnPartiallyConfiguredTentacle(Tentacle

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
// Run these tests in serial to avoid conflicts
[NonParallelizable]
public async Task ShowConfigurationCommandLooksSensibleToHumans(TentacleConfigurationTestCase tc)
{
Expand Down Expand Up @@ -603,6 +616,7 @@ public async Task ShowConfigurationCommandLooksSensibleToHumans(TentacleConfigur
[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
[WindowsTest]
// Run these tests in serial to avoid conflicts
[NonParallelizable]
public async Task WatchdogCreateAndDeleteCommand(TentacleConfigurationTestCase tc)
{
Expand Down