Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run console tests in serial #718

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

nathanwoctopusdeploy
Copy link
Contributor

Background

Run console tests that interact with instance configuration in serial to avoid conflicts

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@nathanwoctopusdeploy nathanwoctopusdeploy marked this pull request as ready for review December 3, 2023 22:41
@nathanwoctopusdeploy nathanwoctopusdeploy requested a review from a team as a code owner December 3, 2023 22:41
@@ -268,7 +268,6 @@ public async Task CommandSpecificHelpAsJsonLooksSensibleToHumans(TentacleConfigu

[Test]
[TentacleConfigurations(scriptServiceToTest: ScriptServiceVersionToTest.None)]
[NonParallelizable]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait so the one that was run in serial could be run in parallel 😆

Copy link
Contributor

@sburmanoctopus sburmanoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwoctopusdeploy nathanwoctopusdeploy merged commit 3391b3d into main Dec 3, 2023
48 checks passed
@nathanwoctopusdeploy nathanwoctopusdeploy deleted the sas/run-console-tests-in-serial branch December 3, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants