Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable Halibut TCP Keepalives by default" #714

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Revert "Enable Halibut TCP Keepalives by default" #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 0 additions & 91 deletions source/Octopus.Tentacle.Tests/Communications/TentacleCommunicationsModuleFixture.cs
View file
Open in desktop

This file was deleted.

7 changes: 1 addition & 6 deletions source/Octopus.Tentacle/Communications/TentacleCommunicationsModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,7 @@ protected override void Load(ContainerBuilder builder)
var configuration = c.Resolve<ITentacleConfiguration>();
var services = c.Resolve<IServiceFactory>();

if (!bool.TryParse(Environment.GetEnvironmentVariable(EnvironmentVariables.TentacleTcpKeepAliveEnabled), out var tcpKeepAliveEnabled))
{
// Default to enabled if the environment variable is not provided
tcpKeepAliveEnabled = true;
}

bool.TryParse(Environment.GetEnvironmentVariable(EnvironmentVariables.TentacleTcpKeepAliveEnabled), out var tcpKeepAliveEnabled);
bool.TryParse(Environment.GetEnvironmentVariable(EnvironmentVariables.TentacleUseRecommendedTimeoutsAndLimits), out var useRecommendedTimeoutsAndLimits);

var halibutTimeoutsAndLimits = useRecommendedTimeoutsAndLimits
Expand Down