Revert "Enable Halibut TCP Keepalives by default" #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ac4a784.
nathanwoctopusdeploy
requested review from
LukeButters,
sburmanoctopus and
acodrington
acodrington
approved these changes
Dec 1, 2023
nathanwoctopusdeploy
deleted the
revert-706-sast/enable-halibut-tcp-keep-alives-by-default
branch
nathanwoctopusdeploy
added a commit
that referenced
this pull request
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #706
Cloud have observed ports get held open for longer than expected on Dynamic Worker when Tentacle is restarted which is causing delays in leasing dynamic workers.
Suspicion is that keep alive are having an impact in this area.
https://app.shortcut.com/octopusdeploy/story/66226/slow-dynamic-worker-initial-lease-time-in-production-east-au-due-to-connection-timeouts-when-configuring-trust
Related to #692