Added Feature to recommend Users from profile page #2948

tsu-ki · 2024-11-18T16:37:38Z

Users can recommend other uses directly from their profile page. I've also added a badge which shows the recommended users.
#2632

Screen.Recording.2024-11-19.at.2.08.44.AM.mov

sentry-io · 2024-11-18T16:37:44Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: website/views/user.py

Function	Unhandled Issue
`get_context_data`	UserProfile.user.RelatedObjectDoesNotExist: UserProfile has no user. ... `Event Count:` 270

_{Did you find this useful? React with a 👍 or 👎}

website/views/user.py

DonnieBLT · 2024-11-19T02:14:54Z

This looks good can you please also add a text area where the user can add a recommendation blurb and if there is a blurb then show it on the profile on the bottom of the page otherwise, having the number count is good.

DonnieBLT

Please see the comment for the changes requested and also please make sure the tests are passing

DonnieBLT · 2024-11-24T00:33:15Z

website/forms.py

+        # Remove any potential template tags or code that might have been entered
+        if blurb:
+            # Remove any HTML or template tags
+            blurb = re.sub(r"<[^>]+>", "", blurb)


getting a security alert for these

website/forms.py

+        if blurb:
+            # Remove any HTML or template tags
+            blurb = re.sub(r"<[^>]+>", "", blurb)
+            blurb = re.sub(r"{%.*?%}", "", blurb)


website/forms.py

+            # Remove any HTML or template tags
+            blurb = re.sub(r"<[^>]+>", "", blurb)
+            blurb = re.sub(r"{%.*?%}", "", blurb)
+            blurb = re.sub(r"{{.*?}}", "", blurb)


website/views/user.py

+
+
+# Add new view for AJAX blurb recommendations
+@require_POST


website/views/user.py

+
+
+@login_required
+def ajax_recommend_user(request, username):


tsu-ki · 2024-11-23T11:28:58Z

@DonnieBLT Added a recommendation blurb which can be added to a User's Profile from Edit Profile Page.
Also Added a feature using which other users can recommend a user directly by clicking on a "Recommend" button which is visible to other users only(not self), without having to manually recommend a user.
Also added a feature to show the total number of recommendations received. Retained the function to show total number of recommended users.
#2632

Screen.Recording.2024-11-23.at.4.53.53.PM.mov

DonnieBLT

please see comments

DonnieBLT · 2024-11-24T00:31:30Z

.pre-commit-config.yaml

      - id: fix-encoding-pragma
        args:
          - --remove
+        language_version: python3.11


I don't think we need all of these

sure, i'll remove them

DonnieBLT · 2024-11-24T00:32:25Z

blt/urls.py

@@ -625,6 +628,9 @@
    path("time-logs/", TimeLogListView, name="time_logs"),
    path("sizzle-daily-log/", sizzle_daily_log, name="sizzle_daily_log"),
    path("blog/", include("blog.urls")),
+    path("recommend/<int:user_id>/", recommend_user, name="recommend_user"),


can you be consistent and use either user id or username - and do we need 3 more urls? Can we do this all with one more?

each of the 3 urls determine, recommend users manually(using the dedicated recommendation feature on user profile) , recommend directly from the button under the recommendation blurb and another is ajax recommendation(this was optional and can be removed)

DonnieBLT · 2024-11-24T00:33:15Z

website/forms.py

+        # Remove any potential template tags or code that might have been entered
+        if blurb:
+            # Remove any HTML or template tags
+            blurb = re.sub(r"<[^>]+>", "", blurb)


getting a security alert for these

DonnieBLT

there are a few changes to make also did you ever get permission from @npxpatel to use his code?

DonnieBLT · 2024-11-24T00:56:21Z

website/admin.py

this is missing imports

umm, can you please tell me which imports are missing from this file? I apologise if I missed any

you can check the original here it has the missing import - https://github.com/OWASP-BLT/BLT/pull/2656/files - did you test this code? This would have thrown an error.

DonnieBLT · 2024-11-24T00:59:45Z

code was originally from here #2656

tsu-ki · 2024-11-24T01:04:18Z

there are a few changes to make also did you ever get permission from @npxpatel to use his code?

I did ask him but he never replied

DonnieBLT · 2024-11-24T01:20:25Z

You also copied our badge to a new project without retaining the license?

tsu-ki · 2024-11-24T01:28:21Z

You also copied our badge to a new project without retaining the license?

Actually, I created this project solely to develop a badge for BLT repository which can be used in the README.md file(#2940) and never intended on using it anywhere else. I was going to archive the repository and delete the badge as soon as the corresponding PR for the issue was merged, I waited so just in case the badge I created could come in-use.
I apologise if this created a misunderstanding, I'll delete the created badge so as not to cause any more confusion.
If there's anything else I can do, please do let me know, again, I'm sorry.

Feature added to recommend Users from profile page

0c5c7e6

github-advanced-security bot found potential problems Nov 18, 2024

View reviewed changes

website/views/user.py Fixed Show fixed Hide fixed

DonnieBLT requested changes Nov 19, 2024

View reviewed changes

tsu-ki requested a review from DonnieBLT November 19, 2024 02:47

tsu-ki added 2 commits November 23, 2024 16:42

Added recommendation blurb feature

5fa1bb6

Added recommendation blurb feature

81b03c8

tsu-ki force-pushed the patch-7 branch from 89f2691 to 81b03c8 Compare November 23, 2024 11:21

github-advanced-security bot found potential problems Nov 23, 2024

View reviewed changes

tsu-ki added 2 commits November 23, 2024 17:06

Testing failed tests

6bc23ce

Fixed Anonymous User Error

e7b63ae

DonnieBLT requested changes Nov 24, 2024

View reviewed changes

DonnieBLT added the requested changes label Nov 24, 2024

DonnieBLT requested changes Nov 24, 2024

View reviewed changes

DonnieBLT mentioned this pull request Nov 24, 2024

feature to Recommend User on profile page #2656

Closed

tsu-ki mentioned this pull request Nov 30, 2024

GSOC 2025 Leaderboard #2916

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Feature to recommend Users from profile page #2948

Added Feature to recommend Users from profile page #2948

tsu-ki commented Nov 18, 2024 •

edited

Loading

sentry-io bot commented Nov 18, 2024

DonnieBLT commented Nov 19, 2024

DonnieBLT left a comment

DonnieBLT Nov 24, 2024

tsu-ki commented Nov 23, 2024 •

edited

Loading

DonnieBLT left a comment

DonnieBLT Nov 24, 2024

tsu-ki Nov 24, 2024

DonnieBLT Nov 24, 2024

tsu-ki Nov 24, 2024

DonnieBLT Nov 24, 2024

DonnieBLT left a comment

DonnieBLT Nov 24, 2024

tsu-ki Nov 24, 2024

DonnieBLT Nov 24, 2024

DonnieBLT commented Nov 24, 2024

tsu-ki commented Nov 24, 2024

DonnieBLT commented Nov 24, 2024

tsu-ki commented Nov 24, 2024 •

edited

Loading



		@login_required
		def ajax_recommend_user(request, username):

Added Feature to recommend Users from profile page #2948

Are you sure you want to change the base?

Added Feature to recommend Users from profile page #2948

Conversation

tsu-ki commented Nov 18, 2024 • edited Loading

sentry-io bot commented Nov 18, 2024

🔍 Existing Issues For Review

DonnieBLT commented Nov 19, 2024

DonnieBLT left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tsu-ki commented Nov 23, 2024 • edited Loading

DonnieBLT left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DonnieBLT left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DonnieBLT commented Nov 24, 2024

tsu-ki commented Nov 24, 2024

DonnieBLT commented Nov 24, 2024

tsu-ki commented Nov 24, 2024 • edited Loading

tsu-ki commented Nov 18, 2024 •

edited

Loading

tsu-ki commented Nov 23, 2024 •

edited

Loading

tsu-ki commented Nov 24, 2024 •

edited

Loading