Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature to Recommend User on profile page #2656

Closed
wants to merge 4 commits into from

Conversation

npxpatel
Copy link
Contributor

@npxpatel npxpatel commented Aug 18, 2024

  • User can recommend others on their profile
  • Created a page to make recommendations

fixes issue -#2632

BLT.-.Brave.2024-08-18.17-42-08.mp4

Copy link

sentry-io bot commented Aug 18, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: website/views.py

Function Unhandled Issue
get_context_data AttributeError: 'NoneType' object has no attribute 'github' /is...
Event Count: 100

Did you find this useful? React with a 👍 or 👎

@npxpatel
Copy link
Contributor Author

@DonnieBLT any feedback or suggestions you might have .

@DonnieBLT
Copy link
Collaborator

This is so you can recommend a user like "Sarthak is a good contributor"

@npxpatel
Copy link
Contributor Author

So instead of a new route "/recommend" , do we have to put up a FORM in the profile page to recommend a user ? If so, where do we display the list of recommendations by a user.

@DonnieBLT
Copy link
Collaborator

Yes, both on the profile page.

@npxpatel
Copy link
Contributor Author

Is this method of showing recommendations made by a user correct ( in the video of this PR) , So the changes to make is putting that recommendation FORM in the profile page ?

@DonnieBLT
Copy link
Collaborator

Yes

@npxpatel
Copy link
Contributor Author

final work :

BLT.mp4

@tsu-ki
Copy link
Contributor

tsu-ki commented Nov 15, 2024

@npxpatel can i work on this issue, if you're okay with that?

@DonnieBLT
Copy link
Collaborator

closing due to this PR - I have added attribution #2948

@DonnieBLT DonnieBLT closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants