Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cohortId and use cohortIds #193

Merged
merged 15 commits into from
Jan 16, 2024
Merged

Deprecate cohortId and use cohortIds #193

merged 15 commits into from
Jan 16, 2024

Conversation

ginberg
Copy link
Collaborator

@ginberg ginberg commented Apr 5, 2023

see #188, for the exported functions I deprecated cohortId and added cohortIds. For internal functions, I just replaced cohortId by cohortIds

@ginberg ginberg requested a review from anthonysena April 5, 2023 12:40
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (be11ea5) 93.34% compared to head (b7c342e) 93.06%.

Files Patch % Lines
R/GetDefaultCovariates.R 28.57% 5 Missing ⚠️
R/CovariateData.R 85.71% 3 Missing ⚠️
R/GetCovariatesFromOtherCohorts.R 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #193      +/-   ##
===========================================
- Coverage    93.34%   93.06%   -0.28%     
===========================================
  Files           16       16              
  Lines         1412     1414       +2     
===========================================
- Hits          1318     1316       -2     
- Misses          94       98       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merge branch 'develop' into cohortIds

# Conflicts:
#	R/CovariateData.R
#	R/GetCovariates.R
#	R/GetCovariatesFromCohortAttributes.R
#	R/GetDefaultCovariates.R
#	R/HelperFunctions.R
#	R/UnitTestHelperFunctions.R
#	extras/VignetteDataFetch.R
#	man/createEmptyCovariateData.Rd
#	tests/testthat/test-Aggregation.R
#	tests/testthat/test-CovariateData.R
#	tests/testthat/test-GetCovariates.R
#	tests/testthat/test-GetCovariatesTemporalSequence.R
#	tests/testthat/test-HelperFunctions.R
#	tests/testthat/test-Table1.R
#	tests/testthat/test-query-no-fail.R
#	tests/testthat/test-spot-checks.R
#	tests/testthat/test-tidyCovariates.R
#	vignettes/CreatingCovariatesUsingCohortAttributes.Rmd
#	vignettes/CreatingCustomCovariateBuilders.Rmd
#	vignettes/CreatingCustomCovariateBuildersKorean.Rmd
#	vignettes/UsingFeatureExtraction.Rmd
#	vignettes/UsingFeatureExtractionKorean.Rmd
@ginberg ginberg merged commit 8b0e7d7 into develop Jan 16, 2024
7 of 10 checks passed
@anthonysena anthonysena linked an issue Feb 2, 2024 that may be closed by this pull request
@anthonysena anthonysena deleted the cohortIds branch February 2, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate cohortId and use cohortIds
1 participant