Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate cohortId and use cohortIds #188

Closed
anthonysena opened this issue Mar 22, 2023 · 0 comments · Fixed by #193
Closed

Deprecate cohortId and use cohortIds #188

anthonysena opened this issue Mar 22, 2023 · 0 comments · Fixed by #193
Assignees
@ginberg
Milestone
V3.4.0

Comments

@anthonysena
Copy link
Collaborator

anthonysena commented Mar 22, 2023 •
edited
Loading

Yes @gowthamrao , I think you're right. The cohortId field in any covariate builder (including getDbCovariateData()) allows a vector of cohort IDs, but is still called cohortId (singular) for historical reasons. I just forgot when creating the input checks for getDbCohortBasedCovariatesData(). I'll modify the check, and add a unit test for multiple cohort IDs.

@anthonysena : perhaps it is time to introduce a cohortIds argument, and deprecate cohortId?

Originally posted by @schuemie in #167 (comment)
@anthonysena anthonysena added this to the v4.0.0 milestone Mar 22, 2023
@ginberg ginberg self-assigned this Apr 4, 2023
ginberg added a commit that referenced this issue Apr 4, 2023
@ginberg
#188 cohortIds instead of cohortId
bfaa747
ginberg added a commit that referenced this issue Apr 4, 2023
@ginberg
#188 update doc
7aab388
ginberg added a commit that referenced this issue Apr 5, 2023
@ginberg
#188 deprecate filterByCohortDefinitionId
7df638f
ginberg added a commit that referenced this issue Apr 5, 2023
@ginberg
#188 update extras/vignettes
298675b
@ginberg ginberg mentioned this issue Apr 5, 2023
Merged
@ginberg ginberg modified the milestones: v4.0.0, V3.4.0 Jan 17, 2024
@anthonysena anthonysena linked a pull request Feb 2, 2024 that will close this issue
Deprecate cohortId and use cohortIds #193
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ginberg ginberg

Labels
None yet
Projects
None yet
Milestone
V3.4.0
Development

Successfully merging a pull request may close this issue.

Deprecate cohortId and use cohortIds OHDSI/FeatureExtraction
2 participants
@ginberg @anthonysena