Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and tests #200

Merged
merged 10 commits into from
Mar 7, 2024
Merged

Fix build and tests #200

merged 10 commits into from
Mar 7, 2024

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Feb 22, 2024

follow-up to #197 and #199

first step: show that CI currently fails

I had to add download=True anyway. It now succeeds.

@bertsky bertsky requested a review from kba February 22, 2024 11:11
@bertsky bertsky marked this pull request as ready for review February 22, 2024 12:06
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (08a020f) to head (d5724ce).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   52.43%   52.43%           
=======================================
  Files          12       12           
  Lines        1377     1377           
  Branches      335      335           
=======================================
  Hits          722      722           
  Misses        531      531           
  Partials      124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikegerber
Copy link
Contributor

Fixed #202 for me, for a manual install of Tesseract (make install-tesseract from here)

@bertsky
Copy link
Collaborator Author

bertsky commented Mar 6, 2024

d5724ce was for sirfz/tesserocr#343 (which has now been merged, so we could even go to tesserocr:master).

@kba kba merged commit d5724ce into OCR-D:master Mar 7, 2024
5 checks passed
kba added a commit to OCR-D/ocrd_all that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants