Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate Tesseract build to ocrd_tesserocr #409

Merged
merged 10 commits into from
Mar 7, 2024

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Feb 22, 2024

- remove rules and defs for Tesseract build
- delegate targets for ocrd_tesserocr executables (including Tesseract CLI)
  to ocrd_tesserocr rules
- keep targets `{clean,install}-tesseract` and `install-tesseract-training`
  (also delegating to ocrd_tesserocr rules), but decouple from `all`
- remove tesseract and tesserocr submodules
- ensure ocrd_tesserocr is checkout out recursively, too
@bertsky
Copy link
Collaborator Author

bertsky commented Feb 22, 2024

@kba do you have any idea why CI does not trigger on this PR? In CircleCI config, forked PR building is still enabled, but I cannot even see the PR...

@bertsky bertsky force-pushed the delegate-tesseract-build branch from 670a6cf to 7f19746 Compare February 23, 2024 00:20
@bertsky bertsky force-pushed the delegate-tesseract-build branch from 7f19746 to 144b642 Compare February 23, 2024 00:20
@bertsky bertsky requested review from kba and joschrew March 5, 2024 21:06
@bertsky
Copy link
Collaborator Author

bertsky commented Mar 6, 2024

I don't know why it does not trigger the CI here, but at least it did on my fork.

Copy link

@joschrew joschrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for notifying me. I have looked through the code and I am currently trying to test by building the Dockerimage. Probably it is not necessary to wait for me here.

@kba kba merged commit b9d6e31 into OCR-D:master Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants